Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] spot domain 구현 ( Feature/17 -> dev ) #46

Merged
merged 34 commits into from
Feb 8, 2024
Merged

[Feat] spot domain 구현 ( Feature/17 -> dev ) #46

merged 34 commits into from
Feb 8, 2024

Conversation

sanggae4133
Copy link
Contributor

@sanggae4133 sanggae4133 commented Feb 8, 2024 •
edited
Loading

✨ PR 유형

어떤 변경 사항이 있나요??

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

🛠️ 작업내용

spot domain 관련 기능 구현입니다.

📋 추후 진행 상황

Image domain 관련 기능 구현
like spot API 구현
gusetbook API 구현

📌 리뷰 포인트

✅ Checklist

PR이 다음 요구 사항을 충족하는지 확인해주세요

  • 커밋 메시지 컨벤션에 맞게 작성했습니다
  • 유지-보수를 위해 주석 처리를 잘 작성했습니다

sanggae4133 and others added 29 commits January 23, 2024 02:11
@sanggae4133
[Feat] Spot.java 구현
593b1de 
ERD 맞춰 기초적인 Spot entity column 생성
@sanggae4133
[Feat] spot service createspot 구현
81eb69b
@sanggae4133
[Feat] spot service createspot 구현
df07706
@sanggae4133
[Feat] implement basic part of image domain
8b21e5b
@sanggae4133
[Feat] checkout origin
7f1d255
@sanggae4133
[Feat] compare to merge
bfd7f4c
@sanggae4133
[Feat] compare to merge
b72fea1
@sanggae4133
Merge pull request #33 from AR-TTUBEOG/feature/29
9f244fa 
Feature/17 <- Feature/29
@sanggae4133
[Feat] commit modified by transfer
23b2ce5
@sanggae4133
[Feat] 산책스팟 createSpot, findBySpotId 구현
474d8fa
@sanggae4133
[Feat] updateSpot API 구현
d75f1a4
@sanggae4133
[Feat] deleteSpot API implement
eed4365
@sanggae4133
[Feat] deleteSpot API implement
36e9a05
@sanggae4133
[Feat] spotController request 수령 구체화
6488380
@sanggae4133
[Feat] guestbookservice 초안
37c8a9b
@sanggae4133
[Feat] createImage 구현
72791c6
@sanggae4133
[Feat] updateImage 구현
68f661d
@sanggae4133
[Feat] deleteImage 구현
12909ad
@sanggae4133
[Feat] deleteImage 구현
036253a
@sanggae4133
[Refac] spot service 리펙토링
f6e3a9b
@sanggae4133
Merge branch 'feature/17' into dev
01cee50
@sanggae4133
Merge branch 'dev' of https://github.com/AR-TTUBEOG/Back-Spring into …
0b4de1a 
…feature/17
@sanggae4133
Merge branch 'dev' into feature/17
fbcf059
@sanggae4133
Merge remote-tracking branch 'origin/dev' into dev
a1464e3
@sanggae4133
Merge branch 'dev' into feature/17
79e6990
@sanggae4133
[refac] merge with dev
e27a740
@sanggae4133
[feat] change user princible to httpserveletrequest
7096525
@sanggae4133
[refac] refac security config
7e82c45
@sanggae4133
[feat] implement just spot service
52d0709
@sanggae4133 sanggae4133 requested a review from choeun7 February 8, 2024 14:23
@sanggae4133 sanggae4133 requested review from arinming and removed request for choeun7 February 8, 2024 14:23
@sanggae4133 sanggae4133 self-assigned this Feb 8, 2024
@sanggae4133 sanggae4133 added the ✨ feature 기능 추가 label Feb 8, 2024
choeun7
choeun7 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@choeun7 choeun7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS 이미지까지 화이팅입니다! 고생하셨습니다.

@arinming
Copy link
Member

arinming commented Feb 8, 2024

LGTM!

Jeongmin39
Jeongmin39 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Jeongmin39 Jeongmin39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~

arinming
arinming approved these changes Feb 8, 2024
View reviewed changes
src/main/java/com/ttubeog/domain/spot/application/SpotService.java
spotRepository.save(spot);

/*
// 이미지 저장
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 주석처리는 뭐죵?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 예정입니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image create 부분은 문제 없는데, image service update method가 문제가 있어서 한 번에 수정해서 다른 pr로 올릴게요

@sanggae4133 sanggae4133 merged commit 2d4020a into dev Feb 8, 2024
1 check failed
@sanggae4133 sanggae4133 deleted the feature/17 branch February 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeongmin39 Jeongmin39 Jeongmin39 approved these changes

@choeun7 choeun7 choeun7 approved these changes

@arinming arinming arinming approved these changes

Assignees

@sanggae4133 sanggae4133

Labels
✨ feature 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanggae4133 @arinming @Jeongmin39 @choeun7