[Feat] 카카오 로그인 초기 세팅 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeongmin39
approved these changes
Jan 18, 2024
Jeongmin39
reviewed
Jan 18, 2024
| @@ -37,21 +37,21 @@ public OAuth2User loadUser(OAuth2UserRequest oAuth2UserRequest) throws OAuth2Aut | |||
| private OAuth2User processOAuth2User(OAuth2UserRequest oAuth2UserRequest, OAuth2User oAuth2User) { | |||
| OAuth2UserInfo oAuth2UserInfo = OAuth2UserInfoFactory.getOAuth2UserInfo(oAuth2UserRequest.getClientRegistration().getRegistrationId(), oAuth2User.getAttributes()); | |||
| DefaultAssert.isAuthentication(!oAuth2UserInfo.getEmail().isEmpty()); | |||
|
|
|||
| Optional<Member> userOptional = memberRepository.findByEmail(oAuth2UserInfo.getEmail()); | |||
There was a problem hiding this comment.
이 부분만 memberOptional이 아니고 userOptional인 건 이유가 있나요?!
궁금해서 질문 남깁니다 ,,!
sanggae4133
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
어떤 변경 사항이 있나요??
🛠️ 작업내용
[ 작업한 내용을 작성해주세요 ]
JWT, Security, Kakao login setting
📋 추후 진행 상황
[ 다음에 진행할 작업에 대해 작성해주세요 ]
[ 현재 커밋 후 풀리퀘 다음으로 작업 내용을 적어주면 됩니다 ]
카카오 로그인 구체화
📌 리뷰 포인트
[ 어떤 부분을 잘 체크해야하는지 작성해주세요 ]
웹이 아닌 앱과 협업시 카카오 로그인 + JWT + Security를 활용한 레퍼런스를 많이 참고했는데,
초은님이 기존에 세팅해두신 global 패키지와 겹치는 부분이 많아보여요!
금요일에 어떤 코드를 활용해야 할 지 논의 해보면 좋을 것 같습니다!
✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요