From b39e2596260375ba12e1223a5b54a5fb19378469 Mon Sep 17 00:00:00 2001 From: Brian2074 Date: Sun, 10 Nov 2024 22:36:11 +0800 Subject: [PATCH] fix(ci): use secrets for Docker Hub credentials Updated the GitHub Actions workflow to use secrets for Docker Hub username and password instead of hardcoding them. This enhances security by keeping sensitive information out of the repository. --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 90abe37..252d974 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,8 +18,8 @@ jobs: - name: Log in to Docker Hub uses: docker/login-action@v2 with: - username: "brian247" # Docker Hub username stored in secrets - password: "Lian238@Docker" # Docker Hub password stored in secrets + username: ${{ secrets.DOCKER_USERNAME }} # Docker Hub username stored in secrets + password: ${{ secrets.DOCKER_PASSWORD }} # Docker Hub password stored in secrets # Step 3: Build Docker image - name: Build Docker image