Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manta tool does not output any file by default #660

Open
bgruening opened this issue Jan 31, 2024 · 5 comments
Open

manta tool does not output any file by default #660

bgruening opened this issue Jan 31, 2024 · 5 comments

Comments

@bgruening
Copy link
Contributor

The outputs are all booleans and it is possible to submit a job with NO output. Even worse its the default setting :)

@drosofff
Copy link
Member

Yeah... You probably did not notice it @bgruening but I am systematically refreshing the tools. Last weeks I was on Lumpy-Smoove and the next one on the list is... Manta !

I fear the worst !

Shall I jump directly to mapping_quality_stats ? I need to sleep... sometimes ;-)

@drosofff
Copy link
Member

@bgruening I have reviewed the manta wrapper.

To me this looks like a monstrous wrapper of wrapper of wrapper. Beside the issue you mentioned last week, it's a miracle that 4/5 tests pass...

We can clarify and fix, for sure.
However,

  • The support to the original tool seems dropped
  • A quick pubmed survey does not give the impression that it is the "blast" of the SV detection (far from)
  • My entourage, which is quite varied, does not use Manta
  • The conda community does not push the manta package like crazy
  • Myself I rather focus on lumpy/smoove or radically different approaches based on B-allele frequencies

Although I can admit that none of these points are really strong and the Manta wrapper has been installed 165 times (not by me !), I have mixed feelings.

Do you think it's worth maintaining the Galaxy Manta wrapper ?

Tell me what you think (other opinions are also welcome), I will definitely take it into account.

@bgruening
Copy link
Contributor Author

I agree we should probably deprecate it. But I'm unsure we we should fix this last problem. It seems to be relatively easy to rearrange the outputs in the Galaxy wrapper, no?

I will hide the tool on the EU server, do you agree?

@drosofff
Copy link
Member

It seems to be relatively easy to rearrange the outputs in the Galaxy wrapper, no?

OK, I'll do it

I will hide the tool on the EU server, do you agree?

No problem with that

@drosofff
Copy link
Member

See PR #669, @bgruening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants