Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: time consuming #10302

Closed
1 task done
fuchao01 opened this issue May 12, 2023 · 2 comments
Closed
1 task done

[Feature Request]: time consuming #10302

fuchao01 opened this issue May 12, 2023 · 2 comments
Labels
upstream Issue or feature that must be resolved upstream

Comments

@fuchao01
Copy link

fuchao01 commented May 12, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

image

In k-diffusion sampling https://github.com/crowsonkb/k-diffusion/blob/master/k_diffusion/sampling.py#LL56C1-L56C1, it takes 170ms

Proposed workflow

TITAN X (Pascal)

Additional information

No response
@fuchao01 fuchao01 added the enhancement New feature or request label May 12, 2023
@Sakura-Luna Sakura-Luna added upstream Issue or feature that must be resolved upstream and removed enhancement New feature or request labels May 12, 2023
@Sakura-Luna
Copy link
Collaborator

Why are you submitting upstream issues here? How are you testing the time overhead?

@akx
Copy link
Collaborator

akx commented May 25, 2023

Closing in favor of the upstream issue crowsonkb/k-diffusion#63

@akx akx closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Issue or feature that must be resolved upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akx @fuchao01 @Sakura-Luna