Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester C] Inconsistency in command format for edit command #197

Closed
soc-pe-bot opened this issue Nov 3, 2023 · 0 comments · Fixed by #205
Closed

[PE-D][Tester C] Inconsistency in command format for edit command #197

soc-pe-bot opened this issue Nov 3, 2023 · 0 comments · Fixed by #205
Assignees
@nikele2001
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
v1.4

Comments

@soc-pe-bot
Copy link

In some parts of the code, the command format is listed as such - "edit ENTRY_INDEX [n/NAME] [p/PHONE_NUMBER] [e/EMAIL] [a/ADDRESS] [nk/NEXT_KIN] [nkp/NEXT_KIN_PHONE] [fp/FINANCIAL_PLAN] [t/TAG]…​​". In other parts like the Summary at the end, the command format is listed as such - "edit ENTRY_INDEX [n/NAME] [p/PHONE_NUMBER] [e/EMAIL] [a/ADDRESS] [nk/NEXT_KIN] [nkp/NEXT_KIN_PHONE] [t/TAG]…​​". It might be good to standardise this so readers are not confused whether or not financial plan can be edited!

Labels: type.DocumentationBug severity.Low
original: dhruvir29/ped#12
@sopa301 sopa301 added bug Something isn't working documentation Improvements or additions to documentation labels Nov 4, 2023
@sopa301 sopa301 added this to the v1.4 milestone Nov 4, 2023
nikele2001 added a commit to nikele2001/tp that referenced this issue Nov 5, 2023
@nikele2001
Fix some UG bugs
907f0ba 
AY2324S1-CS2103T-F12-1#172, AY2324S1-CS2103T-F12-1#190, AY2324S1-CS2103T-F12-1#191, AY2324S1-CS2103T-F12-1#192, AY2324S1-CS2103T-F12-1#194, AY2324S1-CS2103T-F12-1#196, AY2324S1-CS2103T-F12-1#197, AY2324S1-CS2103T-F12-1#198, AY2324S1-CS2103T-F12-1#201, AY2324S1-CS2103T-F12-1#202
@nikele2001 nikele2001 mentioned this issue Nov 5, 2023
Merged
@nikele2001 nikele2001 linked a pull request Nov 5, 2023 that will close this issue
Fix some UG bugs #205
Merged
@sopa301 sopa301 closed this as completed in 6fb54d2 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikele2001 nikele2001

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fix some UG bugs nikele2001/tp
3 participants
@nikele2001 @soc-pe-bot @sopa301