Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating json file with "leap year dates" still has issue #263

Closed
jylow opened this issue Nov 11, 2023 · 1 comment · Fixed by #290
Closed

Updating json file with "leap year dates" still has issue #263

jylow opened this issue Nov 11, 2023 · 1 comment · Fixed by #290
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@jylow
Copy link
Collaborator

jylow commented Nov 11, 2023

Previous issue was fixed with the leap year date thing. However, when json file is changed to include 31-02-2001 or any such not allowed dates, the system still allows parsing and sets the date at the closest date before.

Conversely, changing date to 13-13-2000 will result in an exception being thrown and the file not being able to be opened. Such an issue should be documented in the UG as well.

@jylow jylow added bug Something isn't working documentation Improvements or additions to documentation labels Nov 11, 2023
@sopa301
Copy link
Collaborator

sopa301 commented Nov 11, 2023

As mentioned, we can specify this in the UG.

@sopa301 sopa301 added this to the v1.4 milestone Nov 11, 2023
@sopa301 sopa301 removed the bug Something isn't working label Nov 11, 2023
@AlyssaPng AlyssaPng self-assigned this Nov 11, 2023
@AlyssaPng AlyssaPng linked a pull request Nov 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants