Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs and suggestions for gather feature in DG #278

Closed
Kb-Tay opened this issue Nov 11, 2023 · 0 comments · Fixed by #290
Closed

Bugs and suggestions for gather feature in DG #278

Kb-Tay opened this issue Nov 11, 2023 · 0 comments · Fixed by #290
Assignees
@AlyssaPng
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Kb-Tay
Copy link
Collaborator

Kb-Tay commented Nov 11, 2023 •
edited
Loading

image

Dependendency should not have a multiplicity, if not it would be an association. Glancing at the code, it seems like GatherEmailPrompt does not have a Person field and is therefore a dependency. Can consider fixing UML to better illustrate the implementation

image
Currently the sequence diagram is cluttered. Maybe it would be better to use reference frames to show in a seperate sequence diagram of what happens in model
@Kb-Tay Kb-Tay added the bug Something isn't working label Nov 11, 2023
@Kb-Tay Kb-Tay changed the title Bug in Gather Command Class diagram Bugs and suggestions for gather feature in DG Nov 11, 2023
@AlyssaPng AlyssaPng added the documentation Improvements or additions to documentation label Nov 11, 2023
@AlyssaPng AlyssaPng linked a pull request Nov 12, 2023 that will close this issue
Update documentations for DG, UG and PPP #290
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlyssaPng AlyssaPng

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentations for DG, UG and PPP AlyssaPng/tp
2 participants
@Kb-Tay @AlyssaPng