diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md index d537aa3ead5..def6236bc7c 100644 --- a/docs/DeveloperGuide.md +++ b/docs/DeveloperGuide.md @@ -292,7 +292,7 @@ Step 2. `DeletePersonCommand` is executed, in which `Model#deletePerson("Alex Ye -Step 3. `Model#deletePerson()` will also call `AddressBook#removePerson(Alex Yeoh)` which will remove the target contact from the contact list while removing it from all the groups it was part of. +Step 3. `Model#deletePerson()` will also call `AddressBook#removePerson(Alex Yeoh)` which will remove the target contact from the contact list while removing it from all the groups it was part of by calling `Group#removePerson(Alex Yeoh)`. The following sequence diagram shows how the Delete Person operation works: @@ -308,7 +308,7 @@ The following sequence diagram shows how the Delete Person operation works: The Delete Group command mechanism behaves the same as the Delete Person command above, except it deletes the target `Group` object instead of the `Person` object. -Additionally, `AddressBook#removeGroup(Group g)` will remove the target group 'g' from the group lists of all the members that were a part of it. +Additionally, `AddressBook#removeGroup(Group g)` will remove the target group 'g' from the group lists of all the members that were a part of it by calling `Person#removeGroup(Group g)`. #### Design Considerations diff --git a/docs/diagrams/DeletePersonSequenceDiagram.puml b/docs/diagrams/DeletePersonSequenceDiagram.puml index 8a7cae2f72b..4084c29689a 100644 --- a/docs/diagrams/DeletePersonSequenceDiagram.puml +++ b/docs/diagrams/DeletePersonSequenceDiagram.puml @@ -12,6 +12,8 @@ end box box Model MODEL_COLOR_T1 participant ":Model" as Model MODEL_COLOR +participant ":AddressBook" as AddressBook MODEL_COLOR +participant ":Group" as Group MODEL_COLOR end box [-> LogicManager : execute("delete n/Alex Yeoh") @@ -52,6 +54,18 @@ activate DeletePersonCommand DeletePersonCommand -> Model : deletePerson("Alex Yeoh") activate Model +Model -> AddressBook : removePerson(Alex Yeoh) +activate AddressBook + +AddressBook -> Group : removePerson(Alex Yeoh) +activate Group + +Group --> AddressBook +deactivate Group + +AddressBook --> Model +deactivate AddressBook + Model --> DeletePersonCommand deactivate Model diff --git a/docs/team/coderhuang559.md b/docs/team/coderhuang559.md index 7d5632a9486..7552abcad1e 100644 --- a/docs/team/coderhuang559.md +++ b/docs/team/coderhuang559.md @@ -32,13 +32,13 @@ Given below are my contributions to the project. * **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/#/widget/?search=&sort=groupTitle&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code&since=2023-09-22&tabOpen=true&tabType=authorship&tabAuthor=coderhuang559&tabRepo=AY2324S1-CS2103T-T10-3%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false&chartGroupIndex=36&chartIndex=1) * **Project management**: - * Managed releases `v1.3.0` - `v1.3.3` (4 releases) on GitHub + * Managed releases `v1.3.0` - `v1.4.1` (4 releases) on GitHub * **Documentation**: * User Guide: - * Added documentation for the features `remark` for contacts, `listtime` for contacts, `addmeeting` for groups and `deletetime` for groups. [\#144](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/145) + * Added documentation for the features `remark` for contacts, `listtime` for contacts, `addmeeting` for groups and `deletetime` for groups. [\#144](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/144) * Developer Guide: - * Added implementation details of the `remark` [\#270](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/270/files), `listtime` [\#270](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/270/files), and `addtime` [\#270](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/270/files) features. + * Added implementation details of the `remark`, `listtime` for person and group, `addtime`, and `addmeeting` features [\#270](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/270/files). * Added activity and sequence diagrams for the above functions. * **Contributions beyond project team**