From 27175fb822f1298190354c885cd4d01e97b83ab5 Mon Sep 17 00:00:00 2001 From: ZD292 Date: Tue, 14 Nov 2023 00:50:27 +0800 Subject: [PATCH 1/2] Edit Diagram --- docs/diagrams/ListCommandSequenceDiagram.puml | 5 ++++- docs/team/zd292.md | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/diagrams/ListCommandSequenceDiagram.puml b/docs/diagrams/ListCommandSequenceDiagram.puml index b9394639b26..360dfc58fd2 100644 --- a/docs/diagrams/ListCommandSequenceDiagram.puml +++ b/docs/diagrams/ListCommandSequenceDiagram.puml @@ -15,6 +15,7 @@ participant ":Model" as Model MODEL_COLOR end box + [-> LogicManager : execute("list") activate LogicManager @@ -50,9 +51,11 @@ deactivate AddressBookParser LogicManager -> ListCommand : execute() activate ListCommand -ListCommand -> Model : updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS) + +ListCommand -> Model : updateFilteredPersonList(PREDICATE ...) activate Model + Model --> ListCommand deactivate Model diff --git a/docs/team/zd292.md b/docs/team/zd292.md index 4145ef559f2..80a73cddd69 100644 --- a/docs/team/zd292.md +++ b/docs/team/zd292.md @@ -9,7 +9,7 @@ AddressBook - Level 3 is a desktop address book application used for teaching So Given below are my contributions to the project. -* **New Feature**: Added the ability to group a contact. +* **New Feature**: Added the ability to group a contact. * What it does: Allows the user to group a contact. * Justification: This is a core features which improves the product significantly because it will help our target audience, university students, organise their contacts into their various project groups so that they do not mix up contacts with similar names. This allows university students to neatly organise their contacts. * Highlights: This enhancement affects existing commands and commands to be added in the future. For example, the relationship between group and person is that a group has a list of group members and a person has a list of groups that they are in. @@ -28,14 +28,14 @@ Given below are my contributions to the project. * **Documentation**: * User Guide: - * Added documentation for the features + * Added documentation for the features [\#142](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/142) * Listing Meeting Time From a Group `listtime` * Finding Free Time of a Group `findfreetime` * Viewing Help: `help` * Clearing all Data: `clear` * Developer Guide: - * Add sequence diagram for grouping a contact + * Add sequence diagram for grouping a contact [\#296](https://github.com/AY2324S1-CS2103T-T10-3/tp/pull/296) * Add sequence diagram for FindFreeTime command * Add activity diagram for FindFreeTime command From c3ae386aecc16f3a388d5fb78102c62f63310f5f Mon Sep 17 00:00:00 2001 From: ZD292 Date: Tue, 14 Nov 2023 01:03:20 +0800 Subject: [PATCH 2/2] Edit Diagram --- docs/diagrams/AddCommandSequenceDiagram.puml | 5 +++++ docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml | 4 ++++ docs/diagrams/AddTimeSequenceDiagram.puml | 4 ++++ docs/diagrams/CreateGroupSequenceDiagram.puml | 3 +++ docs/diagrams/DeletePersonSequenceDiagram.puml | 3 +++ ...eDiagram.puml => DeletePersonTimeSequenceDiagram.puml} | 3 +++ docs/diagrams/FindFreeTimeSequenceDiagram.puml | 2 -- docs/diagrams/FindPersonSequenceDiagram.puml | 3 +++ docs/diagrams/GroupPersonSequenceDiagram.puml | 3 --- docs/diagrams/GroupRemarkSequenceDiagram.puml | 8 ++++++++ docs/diagrams/ListCommandSequenceDiagram.puml | 4 ++++ docs/diagrams/ListGroupSequenceDiagram.puml | 3 +++ docs/diagrams/ListTimePersonSequenceDiagram.puml | 3 +++ docs/diagrams/UngroupPersonSequenceDiagram.puml | 2 -- 14 files changed, 43 insertions(+), 7 deletions(-) rename docs/diagrams/{DeletePersonTimeDiagram.puml => DeletePersonTimeSequenceDiagram.puml} (96%) diff --git a/docs/diagrams/AddCommandSequenceDiagram.puml b/docs/diagrams/AddCommandSequenceDiagram.puml index 3d1d9cf1b3b..d55c56c9c59 100644 --- a/docs/diagrams/AddCommandSequenceDiagram.puml +++ b/docs/diagrams/AddCommandSequenceDiagram.puml @@ -99,8 +99,13 @@ activate CommandResult CommandResult --> AddCommand deactivate CommandResult + AddCommand --> LogicManager : result deactivate AddCommand + +AddCommand -[hidden]-> AddressBookParser +destroy AddCommand + [<--LogicManager deactivate LogicManager diff --git a/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml b/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml index 3320a9d337e..90373e42f14 100644 --- a/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml +++ b/docs/diagrams/AddGroupMeetingTimeSequenceDiagram.puml @@ -64,6 +64,10 @@ deactivate CommandResult AddGroupMeetingTimeCommand --> LogicManager : result deactivate AddGroupMeetingTimeCommand + +AddGroupMeetingTimeCommand-[hidden]-> AddressBookParser +destroy AddGroupMeetingTimeCommand + [<--LogicManager deactivate LogicManager diff --git a/docs/diagrams/AddTimeSequenceDiagram.puml b/docs/diagrams/AddTimeSequenceDiagram.puml index b31dacd67a5..a8d0828e94b 100644 --- a/docs/diagrams/AddTimeSequenceDiagram.puml +++ b/docs/diagrams/AddTimeSequenceDiagram.puml @@ -64,6 +64,10 @@ deactivate CommandResult AddTimeCommand --> LogicManager : result deactivate AddTimeCommand + +AddTimeCommand -[hidden]-> AddressBookParser +destroy AddTimeCommand + [<--LogicManager deactivate LogicManager diff --git a/docs/diagrams/CreateGroupSequenceDiagram.puml b/docs/diagrams/CreateGroupSequenceDiagram.puml index 78af0a89544..174dc4b4143 100644 --- a/docs/diagrams/CreateGroupSequenceDiagram.puml +++ b/docs/diagrams/CreateGroupSequenceDiagram.puml @@ -65,6 +65,9 @@ deactivate CommandResult CreateGroupCommand --> LogicManager : result deactivate CreateGroupCommand +CreateGroupCommand -[hidden]-> AddressBookParser +destroy CreateGroupCommand + [<--LogicManager deactivate LogicManager @enduml diff --git a/docs/diagrams/DeletePersonSequenceDiagram.puml b/docs/diagrams/DeletePersonSequenceDiagram.puml index 4084c29689a..d61b92b6bd8 100644 --- a/docs/diagrams/DeletePersonSequenceDiagram.puml +++ b/docs/diagrams/DeletePersonSequenceDiagram.puml @@ -79,6 +79,9 @@ deactivate CommandResult DeletePersonCommand --> LogicManager : result deactivate DeletePersonCommand +DeletePersonCommand -[hidden]-> AddressBookParser +destroy DeletePersonCommand + [<--LogicManager deactivate LogicManager @enduml diff --git a/docs/diagrams/DeletePersonTimeDiagram.puml b/docs/diagrams/DeletePersonTimeSequenceDiagram.puml similarity index 96% rename from docs/diagrams/DeletePersonTimeDiagram.puml rename to docs/diagrams/DeletePersonTimeSequenceDiagram.puml index 695f7726e6c..1efb31234ff 100644 --- a/docs/diagrams/DeletePersonTimeDiagram.puml +++ b/docs/diagrams/DeletePersonTimeSequenceDiagram.puml @@ -65,6 +65,9 @@ deactivate CommandResult DeleteTimeCommand --> LogicManager : result deactivate DeleteTimeCommand +DeleteTimeCommand -[hidden]-> AddressBookParser +destroy DeleteTimeCommand + [<--LogicManager deactivate LogicManager @enduml diff --git a/docs/diagrams/FindFreeTimeSequenceDiagram.puml b/docs/diagrams/FindFreeTimeSequenceDiagram.puml index 56b96a7c4a5..16ff7491b5f 100644 --- a/docs/diagrams/FindFreeTimeSequenceDiagram.puml +++ b/docs/diagrams/FindFreeTimeSequenceDiagram.puml @@ -81,8 +81,6 @@ activate CommandResult CommandResult --> FindFreeTimeCommand deactivate CommandResult -CommandResult-[hidden]-> AddressBookParser -destroy CommandResult FindFreeTimeCommand --> LogicManager deactivate FindFreeTimeCommand diff --git a/docs/diagrams/FindPersonSequenceDiagram.puml b/docs/diagrams/FindPersonSequenceDiagram.puml index 3ba76866817..de0d451ae0b 100644 --- a/docs/diagrams/FindPersonSequenceDiagram.puml +++ b/docs/diagrams/FindPersonSequenceDiagram.puml @@ -65,6 +65,9 @@ deactivate CommandResult FindPersonCommand --> LogicManager : result deactivate FindPersonCommand +FindPersonCommand -[hidden]-> AddressBookParser +destroy FindPersonCommand + [<--LogicManager deactivate LogicManager @enduml diff --git a/docs/diagrams/GroupPersonSequenceDiagram.puml b/docs/diagrams/GroupPersonSequenceDiagram.puml index be476e6fe0c..1ce0ebc31eb 100644 --- a/docs/diagrams/GroupPersonSequenceDiagram.puml +++ b/docs/diagrams/GroupPersonSequenceDiagram.puml @@ -72,9 +72,6 @@ activate CommandResult CommandResult --> GroupPersonCommand deactivate CommandResult -CommandResult -[hidden]-> AddressBookParser -destroy CommandResult - GroupPersonCommand --> LogicManager deactivate GroupPersonCommand diff --git a/docs/diagrams/GroupRemarkSequenceDiagram.puml b/docs/diagrams/GroupRemarkSequenceDiagram.puml index bdbb7896c1b..3c87c6edaa6 100644 --- a/docs/diagrams/GroupRemarkSequenceDiagram.puml +++ b/docs/diagrams/GroupRemarkSequenceDiagram.puml @@ -73,7 +73,15 @@ activate CommandResult CommandResult --> GroupRemarkCommand deactivate CommandResult + + GroupRemarkCommand --> LogicManager: result +deactivate GroupRemarkCommand + +GroupRemarkCommand -[hidden]-> AddressBookParser +destroy GroupRemarkCommand + [<-- LogicManager +deactivate LogicManager @enduml diff --git a/docs/diagrams/ListCommandSequenceDiagram.puml b/docs/diagrams/ListCommandSequenceDiagram.puml index 360dfc58fd2..1f39a2b3e59 100644 --- a/docs/diagrams/ListCommandSequenceDiagram.puml +++ b/docs/diagrams/ListCommandSequenceDiagram.puml @@ -69,6 +69,10 @@ deactivate CommandResult ListCommand --> LogicManager : result deactivate ListCommand +ListCommand -[hidden]-> AddressBookParser +destroy ListCommand + + [<--LogicManager deactivate LogicManager diff --git a/docs/diagrams/ListGroupSequenceDiagram.puml b/docs/diagrams/ListGroupSequenceDiagram.puml index f8289680c91..b8ebb65a698 100644 --- a/docs/diagrams/ListGroupSequenceDiagram.puml +++ b/docs/diagrams/ListGroupSequenceDiagram.puml @@ -66,6 +66,9 @@ deactivate CommandResult ListGroupCommand --> LogicManager : result deactivate ListGroupCommand +ListGroupCommand -[hidden]->AddressBookParser +destroy ListGroupCommand + [<--LogicManager deactivate LogicManager diff --git a/docs/diagrams/ListTimePersonSequenceDiagram.puml b/docs/diagrams/ListTimePersonSequenceDiagram.puml index 7302d0ad597..ea6f7762268 100644 --- a/docs/diagrams/ListTimePersonSequenceDiagram.puml +++ b/docs/diagrams/ListTimePersonSequenceDiagram.puml @@ -66,6 +66,9 @@ deactivate CommandResult ListTimePersonCommand --> LogicManager: result deactivate ListTimePersonCommand +ListTimePersonCommand -[hidden]->AddressBookParser +destroy ListTimePersonCommand + [<-- LogicManager deactivate LogicManager diff --git a/docs/diagrams/UngroupPersonSequenceDiagram.puml b/docs/diagrams/UngroupPersonSequenceDiagram.puml index 7050a1a1cbc..957a7ed0f08 100644 --- a/docs/diagrams/UngroupPersonSequenceDiagram.puml +++ b/docs/diagrams/UngroupPersonSequenceDiagram.puml @@ -66,8 +66,6 @@ activate CommandResult CommandResult --> UngroupPersonCommand deactivate CommandResult UngroupPersonCommand --> LogicManager -CommandResult -[Hidden]-> UngroupPersonCommand -destroy CommandResult deactivate UngroupPersonCommand