Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to filter diagnostic entities #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

w531t4
Copy link
Contributor

@w531t4 w531t4 commented Nov 9, 2024

This PR enhances the existing functionality by allow a user to filter out diagnostic entities from a given domain, using the same logic previously used to filter configuration entities.

Diagnostic entities clutter my dashboard, this gets rid of them.

...
    domains:
      _:
        hide_config_entities: true
        hide_diagnostic_entities: true <----
...

I am certainly no typescript expert, please treat this PR as if a idiot submitted it.

This functionality was requested in issue. Fixes #127

Thanks!

@w531t4 w531t4 force-pushed the diagnostic_entity_filter branch from 499435a to 7ab17c4 Compare November 9, 2024 19:23
@w531t4 w531t4 force-pushed the diagnostic_entity_filter branch from 7ab17c4 to 1492a21 Compare November 9, 2024 20:22
@0xFEEDC0DE64
Copy link

Since this won't get merged and the branch is already quite outdated, I did my best to do the conflicted rebase:
https://github.com/0xFEEDC0DE64/mushroom-strategy

@DigiLive
Copy link
Collaborator

DigiLive commented Jan 6, 2025

Thanks for the effort.

This PR waits on other PR's which needs to be merged first.
Until then, rebasing and merging preliminary has not much use.

@0xFEEDC0DE64
Copy link

what other MR do need to be merged first?
can we please get all of this going, this dashboard generator is almost perfect, but it clutters all my areas with lots of useless entities like esphome free ram, signal strenghts and so on, I really need configs and diagnostics to be hidden by default like the homeassistant default dashboard already does

@DigiLive
Copy link
Collaborator

DigiLive commented Jan 6, 2025

You do realize this is something we do for free/voluntarily in our spare time in between jobs, other projects and personal live?
Also, we have to be careful not to break the scripts by merging PR's blindly into the main branch.
"No conflicts" doesn't mean a merge won't make unexpected (breaking) changes.

I do understand the desire of having an option to hide config/diagnostic entities with a simple setting. Since we already allow to hide config-entities, I will try to prioritize this PR.

In the meanwhile...
Hiding config-entities per domain or for all domains:
https://github.com/AalianKhan/mushroom-strategy/wiki/Strategy-Options#domains

There's also the option to hide cards per entity:
https://github.com/AalianKhan/mushroom-strategy/wiki/Adding-and-Hiding-entities-and-devices#adding-devices-to-areas
https://github.com/AalianKhan/mushroom-strategy/wiki/Strategy-Options#card-options

It takes some time to set the configuration for now, but if you really, really need to hide config/diagnostic entities, you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] add domain.hide_diagnostic_entities similar to domain.hide_config_entities
3 participants