Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrograd subtraction gradient is wrong #1

Open
backsideofdawn opened this issue Mar 24, 2024 · 0 comments
Open

Micrograd subtraction gradient is wrong #1

backsideofdawn opened this issue Mar 24, 2024 · 0 comments

Comments

@backsideofdawn
Copy link

I'm not very experienced with calculus, but my intuition along with ChatGPT tells me that this is wrong:

def __sub__(self, other):
    other = Value(other) if not isinstance(other, Value) else other
    out = Value(self.data - other.data, (self, other), '-')
    def _backward():
        self.grad += 1.0 * out.grad
        other.grad += 1.0 * out.grad
    out._backward = _backward
    return out

Shouldn't the gradient of other be other.grad += -1.0 * out.grad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant