Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On creating and editing, run on create/save has wrong conditional pages #13

Open
Acce0ss opened this issue Oct 30, 2015 · 1 comment
Open

Comments

@Acce0ss
Copy link
Owner

Acce0ss commented Oct 30, 2015

https://github.com/Acce0ss/shellex/blob/master/qml/pages/CreateCommandPage.qml#L117
and
https://github.com/Acce0ss/shellex/blob/master/qml/pages/EditCommandPage.qml#L124
should propably open StartParameterDialog when parameter count is non-zero.

@Acce0ss
Copy link
Owner Author

Acce0ss commented Oct 30, 2015

this https://github.com/Acce0ss/shellex/blob/master/qml/Routine.qml#L38
and
https://github.com/Acce0ss/shellex/blob/master/qml/Routine.qml#L50
should probably have their functionality in the respective pages, to make the accept page transition smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant