-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: layout problem on collapsing a node with many children 2 #5
FIX: layout problem on collapsing a node with many children 2 #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you get rid of the changes in your package.lock file?
I removed the changes to package-lock.json as requested. Just so I can better understand for future contributions, could you share when to include or exclude package-lock.json changes ? |
That was a misunderstanding, i didn't realize you made changes to the package.json file 😄 |
@catosaurusrex2003 please kindly resolve the conflict and please return the package.lock so i can review and merge it 🙏🏽 |
@AceTheCreator done resolving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @catosaurusrex2003
my tiny suggestion would be when a node is collapsed, we should set the center of the view to the collapsed node. wyt?
@AceTheCreator |
one more problem I found is when we open or close any nodes. I am willing to fix this but this will require a lot of changes. |
Yea, feel free to open a new PR 👍🏾 |
Changes in the PR:
removeEdgesByParent
function to remove the remnant edges of a node when we are collapsing it.dagreGraph
andgetLayoutedElements
one level up from Node.tsx -> App.tsx so that every time our App.tsx rerenders a new fresh layout is created.copyfiles
as dev dependency cuz it is used in a script in package.jsonrelated:
asyncapi/website#3334