-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why not Typescript support? #29
Comments
@maykon-oliveira I think it's a good idea, but I personally don't have a lot of experience on setting it up, so feel free to create issues with the needed steps and we can move forward with this, almost all the endpoints are already implemented so we can start something else. Thanks! |
Let's start thinking about it more seriously, since Hacktoberfest is here, let's grab the chance an create a plan and "step" issues. What do you think @alexandreab? |
Hi all. The way things are currently setup, I think a good approach would be to Some other tasks to consider:
Once a decision is made on the bundler, this would be great to start with. |
Eu criei um fork do projeto e adicionei o suporte ao Typescript. https://github.com/maykon-oliveira/sdk-dados-abertos-camara-js/tree/feature/ts-support Se estiver bacana, posso abrir um PR para uma nova branch desse projeto, e podemos dar continuidade a algumas ideias. Incluse tem uma issue aberta #46, que pode ser feita apenas adicionando um plugin no webpack, e ja podemos integrar com o github pages. |
Hey @maykon-oliveira , nice initiative! I think we just need to wait a bit for #44 to be closed, I hope it won't take long. @vinnyA3 Thanks for your comment. I think we can make a new issue specifying exactly the files we will start with and see how it goes. Let's just make sure to mention that this current issue it's blocking further ts implementation. |
Great 😁, but lemme tell you, I removed Parcel from project too. I used webpack to build the sdk and I added a pipeline to minimize the bundle with Unglyfyjs. Parcel was not necessary anymore, so I replaced for webpack. I think you should take a look, and maybe we could separe the PR in two. |
@maykon-oliveira #44 is closed, webpack is in place, fell free to rebase and open your PR :) |
I think should be a good ideia give typescript support to this sdk. What do you think?
The text was updated successfully, but these errors were encountered: