Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not Typescript support? #29

Open
maykon-oliveira opened this issue Oct 19, 2020 · 7 comments · May be fixed by #53
Open

Why not Typescript support? #29

maykon-oliveira opened this issue Oct 19, 2020 · 7 comments · May be fixed by #53

Comments

@maykon-oliveira
Copy link

I think should be a good ideia give typescript support to this sdk. What do you think?

@kimuraz
Copy link
Member

kimuraz commented Oct 21, 2020

@maykon-oliveira I think it's a good idea, but I personally don't have a lot of experience on setting it up, so feel free to create issues with the needed steps and we can move forward with this, almost all the endpoints are already implemented so we can start something else. Thanks!

@kimuraz
Copy link
Member

kimuraz commented Oct 9, 2021

Let's start thinking about it more seriously, since Hacktoberfest is here, let's grab the chance an create a plan and "step" issues. What do you think @alexandreab?

@vinnyA3
Copy link

vinnyA3 commented Oct 9, 2021

Hi all. The way things are currently setup, I think a good approach would be to
start going through the /modules folder and incorporating TS--great for hacktoberfest, as things are modularized & can be handled individually.

Some other tasks to consider:

  • parcel does not perform any type checking. The recommended way to type check is by using an editor with TypeScript support, and using tsc to type check your code in CI.

Once a decision is made on the bundler, this would be great to start with.

@maykon-oliveira
Copy link
Author

Eu criei um fork do projeto e adicionei o suporte ao Typescript.

https://github.com/maykon-oliveira/sdk-dados-abertos-camara-js/tree/feature/ts-support

Se estiver bacana, posso abrir um PR para uma nova branch desse projeto, e podemos dar continuidade a algumas ideias.

Incluse tem uma issue aberta #46, que pode ser feita apenas adicionando um plugin no webpack, e ja podemos integrar com o github pages.

@kimuraz
Copy link
Member

kimuraz commented Oct 10, 2021

Hey @maykon-oliveira , nice initiative! I think we just need to wait a bit for #44 to be closed, I hope it won't take long.
Once the issue is closed, please open a PR with the settings you've have in place so we can openly discuss it and the merge it. For the last year I had a chance to work with Typescript so I hope I can be more useful on this matter. I think this issue can be closed once we have the typescript settings in place, that would be all for now, let me know your thoughts.

@vinnyA3 Thanks for your comment. I think we can make a new issue specifying exactly the files we will start with and see how it goes. Let's just make sure to mention that this current issue it's blocking further ts implementation.

@maykon-oliveira
Copy link
Author

Great 😁, but lemme tell you, I removed Parcel from project too. I used webpack to build the sdk and I added a pipeline to minimize the bundle with Unglyfyjs. Parcel was not necessary anymore, so I replaced for webpack. I think you should take a look, and maybe we could separe the PR in two.

@kimuraz
Copy link
Member

kimuraz commented Oct 30, 2021

@maykon-oliveira #44 is closed, webpack is in place, fell free to rebase and open your PR :)

@maykon-oliveira maykon-oliveira linked a pull request Oct 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants