New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow should generate dist instead of commiting user #143

Closed

npalm opened this issue Sep 14, 2022 · 1 comment

Contributor

npalm commented Sep 14, 2022

Describe the bug

Currently the dist/index.js is created by a user to commit the code. There is a husky check but that can easy be by-passed.

Expected behavior

Two options

Generate the dist/index.js alwasy in CI and overwrite the user one.
Check in CI the dist/index.js in the repo is equal to the CI generated one.

npalm mentioned this issue

fix: Upgrade template workflows #145

Merged

Contributor

ncalteen commented Feb 3, 2025

Closing this issue out as this is no longer relevant.

ncalteen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment