Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite doesn't properly run on Windows #266

Open
ElectronicRU opened this issue Jun 8, 2021 · 5 comments
Open

Test suite doesn't properly run on Windows #266

ElectronicRU opened this issue Jun 8, 2021 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@ElectronicRU
Copy link
Collaborator

erlfmt_formatter_SUITE and sr_formatter_SUITE, which both derive path to test_app from code:priv_dir, fail on Windows, because there it points to _build/test/rebar3_format/priv. I imagine it has something to do with Windows not doing the symlink thing.

This isn't high priority, obviously, but maybe changing the derivation to use __FILE__ could be done.

@elbrujohalcon elbrujohalcon added the bug Something isn't working label Jun 8, 2021
@elbrujohalcon
Copy link
Collaborator

elbrujohalcon commented Jun 8, 2021

Hi @ElectronicRU … Sadly, none of the current maintainers have Windows here. Would be willing to consider becoming an external collaborator for this project and helping us with that, and any other things you would like to help with, of course? 🙏🏻

@ElectronicRU
Copy link
Collaborator Author

@elbrujohalcon sure thing, so long as you can offer some assistance setting up appropriate CI - it'd take me an unreasonably long time to figure out GitHub's workings of it for such a small change, and I already spent enough figuring GitLab's out ^^"

@elbrujohalcon
Copy link
Collaborator

I'm not the CI-guy here… but… I know who can help!!

@paulo-ferraz-oliveira can I use your github-actions expertise yet once more for this project? 🙏🏻

@elbrujohalcon elbrujohalcon added this to the 1.1.0 milestone Jun 8, 2021
@elbrujohalcon
Copy link
Collaborator

@ElectronicRU … you should have a github invitation in your email :)

@paulo-ferraz-oliveira
Copy link
Contributor

Let me try... You want to CI over Windows, right? There's yet no available (that I know of) proper GHA for Windows over OTP 24, but we can work with 23 until either erlef/setup-beam or gleam-lang/setup-erlang get updated.

@elbrujohalcon elbrujohalcon modified the milestones: 1.1.0, 1.1.1 Apr 11, 2022
@elbrujohalcon elbrujohalcon modified the milestones: 1.1.1, 1.1.2 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants