UPDATED README #85
UPDATED README #85
Conversation
There was a problem hiding this comment.
@jm-rives Not bad work Joanna, you've got the essentials. You're missing the pagination, and you should separate the implementation specific details of the API from the controller by creating a Recipe class that your wrapper returns instead of the direct hash.
| puts "*******" + url + "*******" | ||
|
|
||
| # url = BASE_URL + "?q=bacon&from=0&to=10" + "&app_id=#{APP_ID}" + "&app_key=#{APP_KEY}" | ||
|
|
||
| data = HTTParty.get(url) | ||
| # return data['hits'][0]['recipe']['label'] | ||
| recipes = [] |
There was a problem hiding this comment.
You might want to put in some checks in for if the API responds with something unexpected, like if 'hits' is null.
I would also probably setup a recipe class and return either a specific recipe or an array of them. That way you would separate the implementation of the Recipe API from it's use. It would let you switch APIs or other sources of the recipes easier.
| <footer> | ||
| <p class="attribute"> Powered by Edamam |
There was a problem hiding this comment.
This footer could be abstracted into the layout or as a partial.
added reflection