Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require external gtest and remove it from submodules #133

Open
joeljonsson opened this issue Dec 16, 2020 · 5 comments
Open

Require external gtest and remove it from submodules #133

joeljonsson opened this issue Dec 16, 2020 · 5 comments

Comments

@joeljonsson
Copy link
Collaborator

No description provided.

@cheesema
Copy link
Member

Currently macOS requries the use of gtest external for some compilers. Lets make this change following the develop_joel update.

@cheesema
Copy link
Member

Probably should do the same for blosc?

@cheesema
Copy link
Member

cheesema commented Feb 1, 2021

Still need confirmation on how to install this directly on Linux through apt and have this all work.

@krzysg
Copy link
Member

krzysg commented Feb 1, 2021

Just for sake of making it clear - what is a reason to require external gtest (or blosc)? Is there any problem with having it as submodule?

@cheesema
Copy link
Member

cheesema commented Feb 1, 2021

It is a fair point, it may be un-necessary. But I have previously had various issues with compilation around gtest, that an external install seemed to solve.

Maybe one motivation is not suitable, its simply that blosc currently produces a bunch of warning, that during compilation produces a bit of noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants