-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to close the loading bottom sheet (google pay) #312
Comments
Hi @drekyyy, |
Hey @Robert-SD Can you let me know when can we expect a new package version containing this gpay fix? https://github.com/Adyen/adyen-flutter/pull/298 |
Hi @drekyyy, due to peak season and some other features that are still in development we are planning to release v1.2.0 in the first week of January. That release will also include the fix discussed in this issue. We hope that works for you! |
Hi, I'm back to you with my thoughts on these two intents. @camil-adyen @Robert-SD At some time when we bump a library, a duplicated instance started to show up.
Out current implementationintent<intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:host="{my.app.id}" android:scheme="adyencheckout"/>
</intent-filter> return-url
Do you have any idea what the issue is here? |
Hi @kaczmarzk and @drekyyy, Your returnUrl would explain where the "second" intent filter came from. As you correctly outlined, Drop-In ships with an intent filter out of the box. So there is no need to define one when using this integration. It listens to the combination of For components, it is necessary to define an own intent filter to avoid involving the DropInActivity. This gives you full control over the parameter names. When using our example values like But lets keep your already defined values. So your intent filter should look like this: intent-filter <intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:host="{my.app.id}" android:scheme="adyencheckout" android:path="/adyenPayment"/>
</intent-filter> But we also need to make sure that your return-url
Please let me know if the card component finishes and the |
Hi, after the corrections android actually worked as we expected. On the iOS side, is there also a predictable returnUrl?
I would also add that we have given a separate returnUrl per system so we don't have to have them identical.
|
@kaczmarzk, For iOS there is no need to define a path at all. The path is only being needed to work around the DropInActivity when using |
After adding a missing |
Thanks for letting us know that using |
Is your feature request related to a problem? Please describe.
Hey, this is a continuation of https://github.com/Adyen/adyen-flutter/issues/296 where I needed the loading bottom sheet and you helped me out - appreciated again.
But now, Id love an option to close that loading bottom sheet utilizing some method preferably.
It would be helpful because we poll /paymentCapture during 3ds flow for few edge cases and Id really like to have the freedom to close the loading sheet when it fits the flow the best.
Why we poll payment capture during 3ds?
It solves our issue where user, upon entering 3ds redirect webpage and providing a password (doesnt matter if correct) is prompted with back to the app redirection and sometimes, instead of one, has two 'same' apps to choose from - I cant really find a solution to this problem, only one of those apps will return the user back to the app, the other one is a 'ghost' and will result in no action, and upon manually closing the page, we get no result from the component to check if the payment was in fact finished or not.
Flutter 3.13.9, Android 14
Please let me know if you would introduce a method to close the loading bottom sheet for GPay. And any feedback regarding the 'two apps' issue is also welcome.
Describe the solution you'd like
Preferably a method that closes the loading bottom sheet
The text was updated successfully, but these errors were encountered: