Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

84 translate issue #85

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

84 translate issue #85

wants to merge 2 commits into from

Conversation

dungptit1410
Copy link

@dungptit1410 dungptit1410 commented Dec 12, 2024 •
edited by khushboo-singhvi
Loading

Updating Translations for some hardcoded texts.

Fixes:
#84

@dungptit1410 dungptit1410 requested a review from a team as a code owner December 12, 2024 09:40
@dungptit1410 dungptit1410 mentioned this pull request Dec 12, 2024
Open
@khushboo-singhvi khushboo-singhvi linked an issue Dec 16, 2024 that may be closed by this pull request
Some text cannot be translated. #84
Open
@kanevbg
Copy link

kanevbg commented Dec 18, 2024

⚠️ This PR should be updated, it's not escaping the translated strings, it's once security vulnerability and secondly potential to cause unexpected JS errors in cases a translation has double quotes in it.
https://developer.adobe.com/commerce/php/development/security/cross-site-scripting/
I guess escapeJs methods should be used.

@candemiralp
Copy link
Member

Hello @dungptit1410,

Thank you for your contribution. We appreciate your effort to prepare this fix. However, we share @kanevbg's concern about unescaped PHP outputs. Could you please update your PR and escape the outputs via using escapeJs() method?

Best Regards,
Can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acampos1916 acampos1916 acampos1916 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some text cannot be translated.
5 participants
@dungptit1410 @kanevbg @candemiralp @acampos1916 @khushboo-singhvi