Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9534] Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty #2775

Closed
dimitriBouteille opened this issue Oct 22, 2024 · 2 comments · Fixed by #2796
Closed

[ECP-9534] Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty #2775

dimitriBouteille opened this issue Oct 22, 2024 · 2 comments · Fixed by #2796
Assignees
@candemiralp
Labels
Bug report Indicates that issue has been marked as a possible bug

Comments

@dimitriBouteille
Copy link
Contributor

In some case the order comment can be empty (null) so the function str_contains throw exception :(

Capture d’écran du 2024-10-22 10-34-44

Deprecated Functionality: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in /vendor/adyen/module-payment/Controller/Return/Index.php on line 213
@dimitriBouteille dimitriBouteille added the Bug report Indicates that issue has been marked as a possible bug label Oct 22, 2024
@dimitriBouteille dimitriBouteille mentioned this issue Oct 22, 2024
Closed
@candemiralp candemiralp changed the title Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty [ECP-9534] Adyen\Payment\Controller\Return\Index::isResponseAlreadyProcessed() throw exception if comment is empty Oct 28, 2024
@candemiralp
Copy link
Member

Hello @dimitriBouteille,

Thank you for creating this issue. We have created an internal ticket to solve this issue.

Best Regards,
Can

@candemiralp candemiralp self-assigned this Oct 28, 2024
@candemiralp candemiralp mentioned this issue Oct 28, 2024
Closed
@khushboo-singhvi khushboo-singhvi mentioned this issue Nov 4, 2024
Merged
@khushboo-singhvi khushboo-singhvi linked a pull request Nov 4, 2024 that will close this issue
[ECP-9534] Fix success page displayed if payment is canceled #2796
Merged
@khushboo-singhvi
Copy link
Contributor

Hey @dimitriBouteille,

Here is the related PR - #2796
Closing the issue.

Regards!
Khushboo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@candemiralp candemiralp

Labels
Bug report Indicates that issue has been marked as a possible bug
Projects
None yet
Milestone
No milestone
3 participants
@khushboo-singhvi @candemiralp @dimitriBouteille