Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9359] Show installments with stored cards #2717

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[ECP-9359] Show installments with stored cards #2717

merged 3 commits into from
Sep 9, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Aug 19, 2024

Description

When selecting a stored card and setting up CVC not required in configuration, installment options wasn't showing up.
The onBrand callback is where the installments are determined based on the card type. When CVC is not required, the card brand is not correctly identified by the component, and this identification is crucial for enabling the installments.
This PR aims at Manually triggering onBrand callback for brand detection when CVC is hidden.

Tested scenarios

Successful flow of Installments for stored cards when the CVC is not required.

Fixes

@khushboo-singhvi khushboo-singhvi added the Fix Indicates a bug fix label Sep 2, 2024
@khushboo-singhvi khushboo-singhvi changed the title Updating code to show installments with stored cards [ECP-9359]Updating code to show installments with stored cards Sep 2, 2024
@khushboo-singhvi khushboo-singhvi marked this pull request as ready for review September 2, 2024 04:19
@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner September 2, 2024 04:19
@candemiralp candemiralp changed the title [ECP-9359]Updating code to show installments with stored cards [ECP-9359] Updating code to show installments with stored cards Sep 9, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

@candemiralp candemiralp changed the title [ECP-9359] Updating code to show installments with stored cards [ECP-9359] Show installments with stored cards Sep 9, 2024
@candemiralp candemiralp merged commit 2d069e4 into main Sep 9, 2024
16 checks passed
@candemiralp candemiralp deleted the ECP-9359 branch September 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants