-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECP-9359] Show installments with stored cards #2717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
temporarily deployed
to
internal
August 19, 2024 15:51 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
August 19, 2024 15:51 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
August 19, 2024 15:51 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
August 19, 2024 15:51 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
August 19, 2024 15:51 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:10 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:10 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:10 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:10 — with
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:10 — with
GitHub Actions
Inactive
khushboo-singhvi
changed the title
Updating code to show installments with stored cards
[ECP-9359]Updating code to show installments with stored cards
Sep 2, 2024
khushboo-singhvi
temporarily deployed
to
internal
September 2, 2024 04:19 — with
GitHub Actions
Inactive
candemiralp
approved these changes
Sep 2, 2024
SushmitaThakur
approved these changes
Sep 9, 2024
candemiralp
changed the title
[ECP-9359]Updating code to show installments with stored cards
[ECP-9359] Updating code to show installments with stored cards
Sep 9, 2024
Quality Gate passedIssues Measures |
candemiralp
changed the title
[ECP-9359] Updating code to show installments with stored cards
[ECP-9359] Show installments with stored cards
Sep 9, 2024
RokPopov
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When selecting a stored card and setting up CVC not required in configuration, installment options wasn't showing up.
The
onBrand
callback is where the installments are determined based on the card type. When CVC is not required, the card brand is not correctly identified by the component, and this identification is crucial for enabling the installments.This PR aims at Manually triggering
onBrand
callback for brand detection when CVC is hidden.Tested scenarios
Successful flow of Installments for stored cards when the CVC is not required.
Fixes