Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click2Pay: Missing keyboard activation for buttons #3009

Closed
FilipSvozil opened this issue Dec 9, 2024 · 2 comments
Closed

Click2Pay: Missing keyboard activation for buttons #3009

FilipSvozil opened this issue Dec 9, 2024 · 2 comments
Labels
Accessibility Confirmed Issue is confirmed and needs fix

Comments

@FilipSvozil
Copy link

Describe the bug
The "Not you?" and "Resend code" buttons cannot be activated using keyboard.

To Reproduce

  1. Open Click2Pay component
  2. Enter valid email
  3. Tab to the "Not you?" or "Resend code" button (→ focus indicator shows correctly)
  4. Press Space or Enter key to activate the button → doesn't work, and the screen scrolls down instead

Expected behavior
The button's onClick action should execute, and the screen should not scroll down.

Screenshots
Screenshot 2024-12-09 at 9 57 33

Desktop (please complete the following information):

  • MacOS 15
  • Chrome 131 and Safari 18

Additional context
We are using npm package: @adyen/[email protected]


https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/button_role#best_practices

Where possible, it is recommended to use native HTML buttons rather than the button role

@m1aw
Copy link
Contributor

m1aw commented Dec 10, 2024

Hello @FilipSvozil thank you for raising the issue.

This has indeed escaped our review process, we will fix in the coming releases.

@camil-adyen
Copy link
Contributor

Hi @FilipSvozil, we released a fix for this issue in v6.7.0. I'll close the issue for now, but feel free to reopen if you have any other comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Confirmed Issue is confirmed and needs fix
Projects
None yet
Development

No branches or pull requests

3 participants