V6 - Translation fallback

[dimitriBouteille]

Describe the bug

Since the update of the module on v6, I have only problems ...

If I am not mistaken, on v5 there was a fallback system to use the parent locale if the local passed as argument of AdyenCheckout did not exist. Thus:

AdyenCheckout({
	locale: 'fr_CH',
})

The local fr_CH (fr_CA, ...) does not exist in Adyen so it was the local fr_FR that is loaded.

On v6, if I pass the locale fr_CH, it is the translations en_US that are loaded...

To Reproduce

Steps to reproduce the behavior:

1. Create card component with fr_CH or fr_CA locale
2. 💥 The component

Expected behavior

The parent locale must be loaded :

• fr_CH, fr_CA => fr_FR
• it_CH => it_CH
• de_AT, de_CH => de_DE
• ...

[ashrafnazar]

I can confirm that I get errors in the network for en-GB.json as well. If the locale not included in the code, then the component breaks

[sponglord]

@dimitriBouteille - this is correct behaviour for v6, as detailed in the "Breaking changes" here
You are expected to specify a supported locale in the AdyenCheckout config.

The component should not break, however, if the wrong locale is set. Is this actually happening or are you just seeing network errors for the non-existent language json?

[ashrafnazar]

There doesn't seem to be a translation file for en-GB either

[github-actions]

This issue is stale because it has been open 21 days with no activity. Please comment on this issue otherwise it will be closed in 7 days.

[ashrafnazar]

Comment to keep open

[ashrafnazar]

@sponglord - does Adyen accept external contributions?

[sponglord]

@ashrafnazar We have a third-party service to generate the translations for us.

If you'd like us to support another language you can create another issue asking for it. We'll then check if it would benefit other merchants as well and, if it does, we'll ask our third-party service to generate the translation files (so no need to generate the files yourself).

Also keep in mind that even if we don't support a language you can create your own custom translations.