Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a global ICommBoundary variable for communication #14

Open
kh9sd opened this issue Sep 27, 2023 · 0 comments
Open

Make a global ICommBoundary variable for communication #14

kh9sd opened this issue Sep 27, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@kh9sd
Copy link
Member

kh9sd commented Sep 27, 2023

In hindsight, I think it's best to prioritize the convenience of easy telemetry over cleanly modular design.

The core issue is that I think telemetry should be just as easy as printing to std::cout, just include and you can write your call. Currently, we have to pass a ICommBoundary through constructors, not ideal and requires non trivial refactoring and work.

I was thinking of making a basic interface like bind_comm_object() to set the global var, and for now get_comm_object() to get it. Later on I want to move to even more ergonomic interfaces for text logging and formatting.

If you want to try this issue, talk to me first. I'm not convinced this is a 100% good idea so I want to hear your opinion.

@kh9sd kh9sd added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Sep 27, 2023
@anushkakulk anushkakulk self-assigned this Sep 28, 2023
@ritika-gurjar ritika-gurjar self-assigned this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants