Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barometer reads happen serially and thus are slower #93

Open
mcm001 opened this issue Feb 8, 2023 · 0 comments
Open

Barometer reads happen serially and thus are slower #93

mcm001 opened this issue Feb 8, 2023 · 0 comments

Comments

@mcm001
Copy link
Contributor

mcm001 commented Feb 8, 2023

In GitLab by @SamHaggans on Feb 8, 2023, 15:01

In Devices/barometer_ms5607.c in the barometerMs5607_getData, we delay using HAL_DELAY twice for each reading, each for 2ms. This is necessary because of how the barometer samples data to determine pressure. However, we do this twice (once per each physical device), but we could instead perform the conversions in parallel.

To make them work in parallel, we would want to create new functions to start the D1 and D2 conversions so that we could run them in parallel in hm_readSensorData in system/hardware_manager.c, something like:

barometerMs5607_requestD1Conv(&barometerMs5607[i]); for both barometers

Delay

barometerMs5607_readPressure(&barometerMs5607[i]); for both barometers

barometerMs5607_requestD2Conv(&barometerMs5607[i]); for both barometers

Delay

barometerMs5607_readTemp(&barometerMs5607[i]); for both barometers

barometerMs5607_processData(&barometerMs5607[i]); for both

There is also the possibility of, instead of HAL_Delaying (which just does nothing for the time) spending that time reading other sensors or things to save even more time, although just parallelization like above will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant