Admin based Project approval flow #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and corresponding route
…w and corresponding route
…ct controller to check that currentuser is admin or not
… with status Active
… project to only admin or project creator. Also if statements in project form and show page to make changing of status only visible to admin
moves routes to project resource as members and keeps pending_projects as custom route pointing to index action
projecs in REST actions
tochman
changed the title
refactors controller actions
tochman
reviewed
Aug 1, 2021
updates sponsors (out-of-scope) runs migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Project approval flow #3778
Issue addressed
fixes issue #3778 in #3778
To fix the issue I have created methods in the projects controller to either activate or deactivate a project. The methods are only accessible to the admin who also is the only one who can see the corresponding buttons in the project show page that triggers the actions.
I also modified the index method to specifically have @projects refer to only those with (status: "Active").
A new page and method called pending_projects is created to display the projects with (status: "pending") . This method is also only accessible to the user for whom (user.admin? returns true).
I also added a method call access_edit to restrict the access to a project edit page to only the creator and admin. however only the admin can change the status to "Active".
There are also corresponding routes for all the new methods created in routes.rb.