Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use skipAdvance rather than observe when precondition checks fail #10994

Closed
samsiegart opened this issue Feb 12, 2025 · 0 comments · Fixed by #11005
Closed

Use skipAdvance rather than observe when precondition checks fail #10994

samsiegart opened this issue Feb 12, 2025 · 0 comments · Fixed by #11005
Labels
enhancement New feature or request

Comments

@samsiegart
Copy link
Contributor

samsiegart commented Feb 12, 2025 •
edited
Loading

What is the Problem Being Solved?

Context: #10963 (comment)

If the precondition checks fail, for example when the chain is not in the mapping, it currently goes to observed until forwarding. It would be more useful to see an advance-skipped state in this case.

Description of the Design

Change to advanceSkipped

Security Considerations

N/A

Scaling Considerations

N/A

Test Plan

Update the tests to check for advance-skipped

Upgrade Considerations

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fast-usdc): skipAdvance when preconditions fail Agoric/agoric-sdk
1 participant
@samsiegart