Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli wallet limited to vbank NAT assets #8218

Open
dckc opened this issue Aug 17, 2023 · 0 comments
Open

cli wallet limited to vbank NAT assets #8218

dckc opened this issue Aug 17, 2023 · 0 comments
Labels
bug Something isn't working needs-design wallet

Comments

@dckc
Copy link
Member

dckc commented Aug 17, 2023

Describe the bug

In #8156 we're removing the limitation in the walletFactory contract to only vbank assets, which necessarily have AssetKind NAT. But agoric wallet show still has both assumptions.

To Reproduce

Steps to reproduce the behavior:

  1. Run the upgrade test in feat: upgrade walletFactory to go beyond vbank assets #8147 that results in a Place NFT in gov1's wallet
  2. agoric wallet show --from gov1 --keyring-backend=test
  3. See the Place amount value rendered as null: "want":{"Places":["board04980",null]}

both in the balances...

  "purses": [                                                                                                                                                           
    ["board0074",0],                                                                                                                                                    
    ["board04980",null]                                                                                                                                                 
  ],

and in the offer summaries

["game1","join-1692302237720","2023-08-17T19:57:17.720Z","makeJoinInvitation",1,{"give":{"Price":["IST",0.25]},"want":{"Places":["board04980",null]},"payouts":{"Places":["board04980",null],"Price":["IST",0]}}]

Expected behavior

needs design

Platform Environment

@agoric/[email protected]

@dckc dckc added bug Something isn't working wallet needs-design labels Aug 17, 2023
@aj-agoric aj-agoric added this to the Upgrade 12 code complete milestone Sep 7, 2023
@iomekam iomekam removed their assignment Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-design wallet
Projects
None yet
Development

No branches or pull requests

3 participants