-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Dart/Flutter? #1089
Comments
Thanks for trying aider and filing this issue. Did you read the section of that web page about adding language support? |
I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time. |
Hey @paul-gauthier, I found a Is it suitable for Aider and if not, is there anything I can do? |
It has a non standard license. I'm not sure we can use it. |
The tree-sitter-dart repo uses the MIT license which should be okay right? |
Looks like there's already a PR: #2236 |
CC: @malkoG It would be fine to use a tags.scm that was adapted from an MIT-licensed repo. But the one in the PR was sourced from a repo with a custom copyright license. |
I found tree-sitter-dart is MIT license, and in order to check whether if it is really custom license, I diffed those of them I found this: left: https://opensource.org/license/mit If removing line breaks, I got: |
@paul-gauthier is there still a licensing issue? Should I create a separate PR using https://github.com/UserNobody14/tree-sitter-dart/blob/master/queries/tags.scm? Or even a PR from scratch? |
Actually I brought those queries from the repository. And I wrote those queries, too. As you can see the repository, I wrote tests for many cases. @britannio So, you don't need to create separate PR |
@malkoG thank you for working on this PR #2236 ! |
This article describes how aider builds repo-map. If I think is right, |
It appears that the PR does not work. I added test coverage after merging it, but there was a bug in my tests which made them pass incorrectly. py-tree-sitter-languages does not support dart, so this seems unlikely to be salvageable in the short term. I'm looking into it though. |
Issue
Hi, looking at the supported languages on https://aider.chat/docs/languages.html, it does not list Dart / Flutter as one. Wondering if you could consider being able to generate a repository map for it? thank you!
Version and model info
No response
The text was updated successfully, but these errors were encountered: