Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow other mods to change the amount of curses a player has #531

Open
NyanMC opened this issue Oct 11, 2024 · 0 comments
Open

Allow other mods to change the amount of curses a player has #531

NyanMC opened this issue Oct 11, 2024 · 0 comments
Assignees
Labels
awaits review This issue was not yet reviewed by developer enhancement New feature or request

Comments

@NyanMC
Copy link

NyanMC commented Oct 11, 2024

Currently the amount of curses the player is considered to have (a value used exclusively by the Scroll of a Thousand Curses) is determined by the method getCurseAmount in SuperpositionHandler, which merely counts the amount of curse enchantments plus an additional 7 if the cursed ring is equipped. While this functions well enough for the base mod, it becomes difficult for other mods to add additional non-vanilla curses.

Currently, one of my mods adds to the curse total by writing a mixin into this very method and adding curses where necessary. I do not want to have to do this, as it is bad practice to mixin into other mods, however there is no other way to fully implement the functionality I want to add otherwise. The mod with this mixin is currently only on 1.19.2, however it will be on 1.20.1 once its required dependency updates in which this issue would become more relevant as this mod appears to still be actively developed on that version.

@NyanMC NyanMC added awaits review This issue was not yet reviewed by developer enhancement New feature or request labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits review This issue was not yet reviewed by developer enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants