Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show saved intermediate images as preview? #23

Open
XeonG opened this issue Feb 9, 2023 · 3 comments
Open

Show saved intermediate images as preview? #23

XeonG opened this issue Feb 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@XeonG
Copy link

XeonG commented Feb 9, 2023

So webui has the option to disable showing the preview images it generates, which I disabled not sure it made much of a difference to performance,.. however if this addon is enabled it will save and denoise the steps.. so it would be nice if somehow the preview could be switched to use the saved preview images this creates as it generates in replace of the webui version.. would be a nice feature instead of checking the folder as it generates the images.

@AlUlkesh AlUlkesh added the enhancement New feature or request label Feb 22, 2023
@AlUlkesh
Copy link
Owner

I can't imagine that's noticeably faster than showing the preview.

Can you first check, how much time you actually save by disabling?

@XeonG
Copy link
Author

XeonG commented Feb 25, 2023

No live previews
Time taken: 1m 18.25sTorch active/reserved: 7118/9398 MiB, Sys VRAM: 12084/24564 MiB (49.19%)

live previews
Time taken: 1m 23.81sTorch active/reserved: 11728/14008 MiB, Sys VRAM: 16694/24564 MiB (67.96%)

that was "hires on" and "Save every N images: 1"
I dunno maybe not such a big difference on time.. but I'll do some more tests later

@LanceGao97
Copy link

No live previews Time taken: 1m 18.25sTorch active/reserved: 7118/9398 MiB, Sys VRAM: 12084/24564 MiB (49.19%)

live previews Time taken: 1m 23.81sTorch active/reserved: 11728/14008 MiB, Sys VRAM: 16694/24564 MiB (67.96%)

that was "hires on" and "Save every N images: 1" I dunno maybe not such a big difference on time.. but I'll do some more tests later

This is true,
800*1200 base image, no high res fix, 4070Ti GPU,
Setting---LivePreview options
Full 11G GPUram ( from begin to the end)
Approx NN 5G GPUram
Approx Cheap 5G GPUram

I don't even dare to move my mouse when Full,
but I can play video games when APProx NN is on.

the default live preview has some problem, just save preview images shouldnt have those problems for RAM.
your script , not matter on or OFF, GPU RAM is 5G, it looks OK, and it can still record the intermediate images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants