Add support for account new --save-to-file #3425
Open
+230
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
2 times, most recently
from
d251e51 to
9a88d43
Compare
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
9a88d43 to
dfd83e3
Compare
ljedrz
reviewed
Oct 30, 2024
ljedrz
reviewed
Oct 30, 2024
ljedrz
reviewed
Oct 30, 2024
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
2 times, most recently
from
969e5ab to
18df382
Compare
ljedrz
reviewed
Oct 31, 2024
|
One more thing I forgot before: we need to adjust the file's permissions too; see this PR for reference. |
ljedrz
reviewed
Nov 1, 2024
ljedrz
reviewed
Nov 1, 2024
ljedrz
reviewed
Nov 1, 2024
ljedrz
reviewed
Nov 1, 2024
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
8ce2982 to
ef05e86
Compare
ljedrz
reviewed
Nov 6, 2024
ljedrz
reviewed
Nov 6, 2024
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
2 times, most recently
from
85de9df to
739d635
Compare
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
739d635 to
fbde50f
Compare
|
it is failing the Windows CI for some reason: |
|
I can see the problem in the CI. I will fix 👍 |
ljedrz
reviewed
Nov 19, 2024
ljedrz
approved these changes
Nov 19, 2024
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
bdb6400 to
35a1b4e
Compare
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
35a1b4e to
3b097a2
Compare
zkxuerb
approved these changes
Dec 10, 2024
Raphexion
force-pushed
the
nijo/add-accounts-new-save-to-file
branch
from
3b097a2 to
302cb55
Compare
|
@zkxuerb I fixed the formatting that was detected by the CI ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When creating ephemeral networks for integration testing, it is convenient to be able to generate accounts programmatically and save the account information into files, especially the private-key-file for a new account.
Therefore, we introduce the command line switch
--save-to-file.This feature, will create good synergy with the existing feature to use the command-line switch
--private-key-file.The PR is split into two commits
Test Plan
Make sure that you can use the switches
--save-to-fileand--private-key-filetogether when using the command-line interface (cli).Related PRs