Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Change link-time optimization in dev and test #3441

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Raphexion
Copy link

Motivation

This change improves the development cycle in both dev and test, when running the same command multiple times in a row.

On my machine I can see improvements from minutes to seconds. For example when running cargo run and cargo test.

Test Plan

Compare running this commands 3 times in a row with or without this patch

cargo test
cargo run accounts new

Related PRs

None

Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this as long as it doesn't have a negative impact on CI test times (in which case it would still make sense for the dev profile).

This change improves the development cycle in both dev and test,
when running the same command multiple times in a row.

On my machine I can see improvements from minutes to seconds.
For example when running `cargo run` and `cargo test`.

Co-authored-by: Paul Dann <[email protected]>
@Raphexion Raphexion force-pushed the nijo/speed-up-dev-test-cycle branch from 0c33479 to a1918e1 Compare December 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants