Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Th24 looks ugly when using some custom themes #863

Open
dnchshrp opened this issue Oct 26, 2024 · 4 comments
Open

Th24 looks ugly when using some custom themes #863

dnchshrp opened this issue Oct 26, 2024 · 4 comments

Comments

@dnchshrp
Copy link

System Details

Problem
There are visible white lines that appear when using custom themes which makes the UI look ugly:
image
image
image
image

It also would be nice to be able to optionally make the tab separators invisible since they can look bad in some cases:
image

Did you read the FAQ?
Yes

Additional Notes

@dnchshrp dnchshrp changed the title Th24 looks ugly when using a custom theme Th24 looks ugly when using some custom themes Oct 26, 2024
@gz83
Copy link
Collaborator

gz83 commented Oct 26, 2024

Currently, th24 styles should only be adapted to the default theme.

@Alex313031
Copy link
Owner

Alex313031 commented Oct 29, 2024

@gz83 @dnchshrp I can fix the white line outline on the omnibox. The white line under the bookmarks bar, im not sure what that is or why its doing that.

The tab separators are not an issue (from a code perspective): they are behaving normally. Installing this theme on Chrome should also make the separators look like that. Removing the separators would fuck spacing up to no end, however, I might put a flag that tells them to be 0 opacity i.e. transparent to the color on the layer underneath it. The problem is that means yet another command line code path to maintain, just for you or the few that encounter this.

While I want everyone to enjoy thorium, and I am definitely not above taking the time to fix something just for one person, I also have to balance how many times I do stuff like that. I am thinking this should be easy, so I can probably do it for you, but no promises, because if it takes above a certain amount of time or requires modifying too many files, I won't be able to justify it in my head

@dnchshrp
Copy link
Author

OK, thanks for the response! @Alex313031

@Alex313031
Copy link
Owner

@gz83 Yes, but the ultimate goal is to have Th24 work seamlessly, meaning that themes should also work. The only thing I have no idea about is the whole bookmarks bar white line thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants