-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style on hovered tab is not removed when you leave it by moving up #4893
Comments
I see it; but I cannot do the fix: OnMouseMove is not called in this case. |
this is wont-fix because of OnMouseMove is not called for tabs-control. |
There's another issue that is annoying me. Commenting here because perhaps the root cause is the same. One feature of Cuda is that if you hover the status message, a tooltip appears showing the history of previous messages. But at least for me, this tooltip shows up even when mouse quickly crossed status bar, This happens to me when I move the mouse from inside out of Cuda window (from the editor to below Cuda window, crossing status bar). When I move mouse pointer in the opposite direction (from below Cuda window to Cuda editor, also crossing status bar), this issue doesn't happen. So my guess is that Cuda currently is able to detect mouse moved out status bar only if the destination position of the mouse is within Cuda window. It would be good if this can be fixed. If it's hard, I'd like to suggest a way (option?) to disable this popup from showing up on hover, maybe requiring user to click the status bar to show the tooltip instead of showing on hover. |
cuda.mp4 |
Tested it more, on gtk2+qt5 versions. it works already ok for me. I did not stop the mouse cursor over the statusbar, I just moved it (slowly) from top to the bottom, and vice versa. and hint did not appear. hint appears only if I stop the cursor over the statusbar and wait a little. @veksha What is your test result (linux or windows)? |
on Windows, tooltip disappears when mouse moves out of window. |
I just tested in Cuda Qt5 Wayland (i.e. without So apparently, tooltip doesn't use mouse position to decide if it should be displayed, but it should. It appears anyway after the "tooltip delay", but hides if it detects on MOUSEMOVE that mouse is out of window. |
Maybe the option "count of lines in tooltip of last statusbar cell" is good? I may add it. if 0: tooltip is disabled. |
I just tested Cuda GTK and it's affected the same way as in my video. Tooltip doesn't hide even after moving the mouse out of the window. |
The way it stands I'd need to set it as |
I could not yet make hint showing by click. sorry. but I added the option - default.json:
new binaries for gtk2/qt5: |
About original issue- Lazarus event (onMouseLeave) is not called when we move mouse out of the window , so I cannot solve it. about newly added option - let’s discuss it in new topic. |
Tab highlighting shouldn't be removed on leaving Cuda window. Above tabs there is menubar. Highlighting should be removed when we move mouse over menubar (or simply out of the tab). I don't know the code, but it's strange for me this to not be fixable:
Is menubar really that special type of element? |
Yes, it’s painted by OS (only on windows I can change its painting) |
Is Cuda able to check mouse position? Example: a timer of 1s is triggered in loop while a tab is hovered. After the interval, mouse position is checked. If it doesn't match tab coordinates (i.e. mouse is no longer hovering the tab), highlight is removed. |
It’s nice idea, timer, I can reuse existing AppIdleTimer. |
Good to know. Just remembering this issue is not restricted to tabs, it also affects clickable statusbar elements such as |
Should I open a new issue requesting the option to make status message tooltip to be displayed on click instead of on hover? By the way, maybe the idea above can also be applied to this. Maybe, right before the tooltip showing up, Cuda could check mouse position, so that tooltip should only by displayed if mouse is still over status message. Currently, I proved in video tooltip is appearing even when mouse is out of statusbar. |
I don’t know how to show hint by click , I tried it. So new issue won’t help. |
Then I see two possibilities.
|
Way 2 is good. Made the popup menu on click. Wait for the update pls. |
Made changes. let's test linux beta. |
|
For me it works in all 3 cases. Gtk2 and Qt5. Try on X session? |
Disable the tooltip then, using newly added option which I mentioned |
I tried, but with |
Ops, I forgot to support all option values! |
I use Wayland session:
|
Updated betas on the same URL. now you can set new option (statusbar hint lines) to 0 and still have popup on clicking the statusbar-cell.
I cannot see the issue now - for me on X session, gtk2/qt5, all ok. |
Statusbar messages: fixed, thanks. Regarding the highlight issue, I'll try to record a video showing my experience. |
cuda.mp4 |
You need to wait for timer-delay==1000ms. maybe you waited less? |
(Also: you did not leave the window entirely!) |
No. It's how I said: highlight is only removed for status buttons and even there it's only for the random cases the tooltip doesn't appear.
It doesn't change the results, I can assure you. |
I see it now on Wayland session. sometimes its removed though. |
I see that on Wayland session getting of mouse coords works bad - if I move cursor out of the window. old coords of mouse are returned.... |
I made isolated demo and posted bugreport |
I see it is worked around already (Cud 1.213.1 beta). after I move mouse upper, and wait 2-3 secs, tab hover highlight disappears by itself. |
No. At least for me, using latest beta Qt5, tab hover highlight is never removed if mouse is still above tab bar, even if wait a few seconds without moving the mouse. |
Is any event called when mouse is over file menu (or any of its items)? If it does, it can fix this issue. |
on Wayland - it's still bad. |
Actually what you said is true, but only if I run CudaText without the envvar
If you can fix these two issues, then I can run Cuda as a true Wayland application, without needing to set |
When you hover a tab, it gets special background color (white ish for default theme, while normal tabs are gray ish).
When cursor leaves the tab, background color should get back to normal. This happens when you move from tab to tab, from tab to the editor...
But it's not working when you move to above the tab.
cuda.mp4
This video was recorded with menubar visible, but the issue is still reproducible even after disabling it.
The text was updated successfully, but these errors were encountered: