You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just for clarification, in the current draft of #348, I have two workflows: make-live.yml and render-rmds.yml.
render-rmds.yml runs on pull requests to master as a check only (it does not do anything with rendered files).
make-live.yml renders and files PRs, but is currently running only on manual dispatch. We could make this run on every merge to master with a small change to the trigger.
Would that trigger change be sufficient to close this, or are there other things you were thinking of in this issue?
Would that trigger change be sufficient to close this, or are there other things you were thinking of in this issue?
Yes, that would be sufficient. Would it also be possible to restrict the PRs to when we update R Markdown files (untested; mentioned in #299):
on:
push:
branches:
- 'master'paths:
- '**.Rmd'
If that works, I anticipate that we would only get PRs when we need them (could get fancier and ignore paths if we really wanted) and that it would eliminate the need for the manual trigger.
We might also want a failure to yell at us in #science-robots if we remove the manual trigger.
Related to #296 and #299, which I may close in favor of this issue.
Originally posted by @jashapiro in #348 (comment)
The text was updated successfully, but these errors were encountered: