Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Submit a PR with rendered and live versions of notebook upon merge to master #359

Open
jaclyn-taroni opened this issue Feb 20, 2021 · 3 comments
Labels
automate all the things Related to GitHub Actions, generally speaking

Comments

@jaclyn-taroni
Copy link
Member

Related to #296 and #299, which I may close in favor of this issue.

We could check building with every pull requests to master, and submit a PR with rendered/live updates on merge to master?

Originally posted by @jashapiro in #348 (comment)

@jaclyn-taroni jaclyn-taroni added the automate all the things Related to GitHub Actions, generally speaking label Feb 20, 2021
@jashapiro
Copy link
Member

Just for clarification, in the current draft of #348, I have two workflows: make-live.yml and render-rmds.yml.

render-rmds.yml runs on pull requests to master as a check only (it does not do anything with rendered files).

make-live.yml renders and files PRs, but is currently running only on manual dispatch. We could make this run on every merge to master with a small change to the trigger.

Would that trigger change be sufficient to close this, or are there other things you were thinking of in this issue?

@jaclyn-taroni
Copy link
Member Author

Apologies, I missed 8edbe86!

Would that trigger change be sufficient to close this, or are there other things you were thinking of in this issue?

Yes, that would be sufficient. Would it also be possible to restrict the PRs to when we update R Markdown files (untested; mentioned in #299):

on:
  push:
    branches:
    - 'master'
    paths:
    - '**.Rmd'

If that works, I anticipate that we would only get PRs when we need them (could get fancier and ignore paths if we really wanted) and that it would eliminate the need for the manual trigger.

We might also want a failure to yell at us in #science-robots if we remove the manual trigger.

@jaclyn-taroni
Copy link
Member Author

I'm going to take this out of the 2021 March Epic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate all the things Related to GitHub Actions, generally speaking
Projects
None yet
Development

No branches or pull requests

2 participants