Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration helper plugin for CKEditor ignores the value of editor.enterMode #7

Open
AlexanderBilichenko opened this issue Apr 11, 2014 · 1 comment
Open

Configuration helper plugin for CKEditor ignores the value of editor.enterMode #7

AlexanderBilichenko opened this issue Apr 11, 2014 · 1 comment

Comments

@AlexanderBilichenko
Copy link

I think it should be something like this in 'removePlaceholder' method:

root.setHtml( editor.enterMode === CKEDITOR.ENTER_P ? '<p><br/></p>' : (editor.enterMode === CKEDITOR.ENTER_DIV ? '<div><br/></div>' : '<br/>') );

And if so, 'dataIsEmpty' should have condition for <div>
@AlfonsoML
Copy link
Owner

I use the default settings, so it would be better if you could test all the situations that aren't adjusted for div and provide a patch that I can review fast

JulesAchiel added a commit to JulesAchiel/confighelper that referenced this issue May 30, 2019
@JulesAchiel
function removePlaceholder to check editor.enterMode
fcf8850 
This change is essentially the fix for issue AlfonsoML#7
JulesAchiel added a commit to JulesAchiel/confighelper that referenced this issue May 30, 2019
@JulesAchiel
function removePlaceholder to check editor.enterMode
82bf0b1 
This essentially the fix for issue AlfonsoML#7
This was referenced May 30, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexanderBilichenko @AlfonsoML