Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pushout complement for AttrVars #54

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

kris-brown
Copy link
Collaborator

@kris-brown kris-brown commented Mar 19, 2024

This PR redoes how we handle AttrVars for pushout complements in light of #53

The computation is no longer handled pointwise. Although perhaps we can develop a clean understanding of what should happen in terms of pushout complements in a Kleisli category or in the machinery described by this blog post, for now there is just intuition guided by some concrete examples.

Additional checks are needed to see if a match is valid because, if the match is not monic, it could be possible that two variables (which are mapped to different values in I -> R) are identified with each other.

This is a breaking change because we no longer allow rewriting ACSets which themselves have variables (the rules, of course, still have variables, as well as the intermediate state K in between the initial and final state of a rewrite).

@kris-brown kris-brown self-assigned this Mar 19, 2024
@kris-brown kris-brown added the bug Something isn't working label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 98.68421% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.79%. Comparing base (690fe70) to head (79d9548).

Files Patch % Lines
src/categorical_algebra/CSets.jl 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   85.94%   85.79%   -0.15%     
==========================================
  Files          31       31              
  Lines        2020     2063      +43     
==========================================
+ Hits         1736     1770      +34     
- Misses        284      293       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown linked an issue Mar 19, 2024 that may be closed by this pull request
@kris-brown kris-brown merged commit 2263d84 into main Apr 19, 2024
9 checks passed
@epatters epatters deleted the attrvar_pushout_comp branch April 19, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushout complement treatment of attrvars
1 participant