New pushout complement for AttrVars #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redoes how we handle AttrVars for pushout complements in light of #53
The computation is no longer handled pointwise. Although perhaps we can develop a clean understanding of what should happen in terms of pushout complements in a Kleisli category or in the machinery described by this blog post, for now there is just intuition guided by some concrete examples.
Additional checks are needed to see if a match is valid because, if the match is not monic, it could be possible that two variables (which are mapped to different values in
I -> R
) are identified with each other.This is a breaking change because we no longer allow rewriting ACSets which themselves have variables (the rules, of course, still have variables, as well as the intermediate state
K
in between the initial and final state of a rewrite).