Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make renaming not generate as many new scopetags #148

Open
kris-brown opened this issue Mar 20, 2024 · 0 comments
Open

Make renaming not generate as many new scopetags #148

kris-brown opened this issue Mar 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kris-brown
Copy link
Collaborator

There are new features for renaming in the pipeline (#147 and #146) which suffer from a common problem of generating completely fresh ScopeTags for the renamed theory. Consider the following scenario:

Screenshot 2024-03-20 at 10 49 45 AM

We rename * to + in both ThGrp and ThAbGrp (which extends ThGrp with a commutativity axiom). With the present setup, it will not be the case that ThAddGrp will be a proper inclusion of ThAddAbGrp.

One way to address this is to make the data to rename ThGrp (resp. ThAbGrp) be the renaming morphism (as generated by the existing tooling) from ThMon to ThAddMon as well as an inclusion from ThMon into ThGrp (resp ThAbGrp). This fancier renaming function will make sure to use the fresh scopetags from ThAddMon in both ThAddGrp and ThAddAbGrp.

Screenshot 2024-03-20 at 10 50 59 AM

@kris-brown kris-brown added the enhancement New feature or request label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant