useTemplate now has optional templatedata

AliceO2Group · Dec 11, 2024 · eb5a068 · eb5a068
1 parent 64a44c7
commit eb5a068
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/public/views/Logs/Create/TemplatedLogCreationModel.js b/lib/public/views/Logs/Create/TemplatedLogCreationModel.js
@@ -56,28 +56,26 @@ export class TemplatedLogCreationModel extends LogCreationModel {
     constructor(onCreation, relations, templateKey, templateData) {
         super(onCreation, relations);
 
-        this._templateData = templateData;
-
         /**
          * @type {logTemplateKey|null}
          * @private
          */
         this._templateKey = null;
 
         if (templateKey) {
-            this.useTemplate(templateKey);
+            this.useTemplate(templateKey, templateData);
         }
     }
 
     /**
      * Defines the template to use, defined by its key
      *
      * @param {logTemplateKey|null} key the key of the template to use (there may be no model for the given key)
-     * @param {object} templateData the template data of the log
+     * @param {object} [templateData={}] the optional template data
      * @return {void}
      */
-    useTemplate(key) {
-        const templateModel = logTemplatesFactory(key, this._templateData);
+    useTemplate(key, templateData={}) {
+        const templateModel = logTemplatesFactory(key, templateData);
         if (templateModel) {
             templateModel.bubbleTo(this);
         }

diff --git a/lib/public/views/Logs/Create/templates/OnCallLogTemplate.js b/lib/public/views/Logs/Create/templates/OnCallLogTemplate.js
@@ -128,6 +128,7 @@ export class OnCallLogTemplate extends Observable {
      * @return {boolean} true if the form is valid
      */
     get isValid() {
+        console.log(this.formData)
         return Boolean(this.formData.shortDescription.length >= 4 && this.formData.shortDescription.length <= 100
             && this.formData.detectorOrSubsystem
             && this.formData.severity