Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pull request template [DT-5996] #38

Merged
merged 2 commits into from
Nov 12, 2024
Merged

chore: Pull request template [DT-5996] #38

merged 2 commits into from
Nov 12, 2024

Conversation

lanesawyer
Copy link
Collaborator

What

Adds a pull request template (which I'm using right now!)

How

Copied our PR template from bkp-client and tweaked it for the needs of this repository

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested review from a team, Jarbuckle and TheMooseman and removed request for a team November 12, 2024 23:05
@lanesawyer lanesawyer merged commit 1fe8fbd into main Nov 12, 2024
5 checks passed
@lanesawyer lanesawyer deleted the lane/DT-5996-pr-template branch November 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMooseman TheMooseman TheMooseman approved these changes

@Jarbuckle Jarbuckle Awaiting requested review from Jarbuckle Jarbuckle is a code owner automatically assigned from AllenInstitute/app-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanesawyer @TheMooseman