Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Remove all uses of XValue / create_unit_with_value #1184

Closed
2 tasks done
dbirman opened this issue Dec 6, 2024 · 0 comments · Fixed by #1224
Closed
2 tasks done

[2.0] Remove all uses of XValue / create_unit_with_value #1184

dbirman opened this issue Dec 6, 2024 · 0 comments · Fixed by #1224
Assignees
@dbirman
Labels
breaking Breaking changes
Milestone
data-schema 2.0 a...

Comments

@dbirman
Copy link
Member

dbirman commented Dec 6, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
aind-data-schema-model v1.0 will no longer have XValue classes. Remove and replace with the field/field_unit pattern.

Describe the solution you'd like

  • XValue classes removed, replaced with field/field_unit
  • Upgrader in place for v1.X -> 2.0
@dbirman dbirman added the breaking Breaking changes label Dec 6, 2024
@saskiad saskiad changed the title Remove all uses of XValue / create_unit_with_value [2.0] Remove all uses of XValue / create_unit_with_value Dec 16, 2024
@saskiad saskiad added this to the v2.0 milestone Jan 2, 2025
@dbirman dbirman linked a pull request Jan 14, 2025 that will close this issue
refactor: replace create_unit_with_value with field/field_unit #1224
Merged
@dbirman dbirman closed this as completed Jan 14, 2025
@dbirman dbirman self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbirman dbirman

Labels
breaking Breaking changes
Projects
None yet
Milestone
data-schema 2.0 and data-schema-model...
Development

Successfully merging a pull request may close this issue.

refactor: replace create_unit_with_value with field/field_unit AllenNeuralDynamics/aind-data-schema
2 participants
@saskiad @dbirman