-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cascading): option to bypass non-latest minor branch #2473
base: main
Are you sure you want to change the base?
Conversation
37d807b
to
fd66a43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
fd66a43
to
e586aba
Compare
e586aba
to
5cecb54
Compare
5cecb54
to
167e161
Compare
167e161
to
63c73c0
Compare
63c73c0
to
ef7d65a
Compare
/** Determine if the reviewers are bypassed */ | ||
/** | ||
* Determine if the reviewers are bypassed | ||
* Note: This option is not supported on Github anymore due to Github Api change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are not we deprecating it ?
If we want to be able to re-use that part of the code for another platform,
we may extract that part in a dedicated package
else it seems to be stricly done for GitHub and then we should deprecate this proprety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not deprecate this option because I think that as the cascading is already today platform agnostic (event if it is implemented only for Github) and this option still make sense for supporting platform, it would be weird to remove it in 1 year to follow the unique implementation to potentially seeing it reappear after a while because of a new implementation.
It made more sense for me to keep it and warn the Github users instead, but I am OK to change if needed.
PS: To implement another platform support, there is no need to extract code, it's the bot that should switch the implementation according to the received message. So today it is already ready to support multi platform as it is
@@ -2,6 +2,7 @@ | |||
"$schema": "../apps/github-cascading-app/schemas/config.schema.json", | |||
"bypassReviewers": true, | |||
"labels": ["cascading"], | |||
"onlyCascadeOnHighestMinors": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably not activate it for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ? I was thinking that it is actually the issue we have today with the non-removed prerelease branches and the policy supporting only the latest minor of each major?
Saw a configuration I would discuss of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a case where we want to skip non-latest minors?
Wouldn't this create incoherence and confusion among the different branches / code levels?
e5651ac
to
5657885
Compare
5657885
to
c4a10be
Compare
Not sure to understand why. |
Proposed change
Option to bypass non-latest minor branch on cascading bot
Related issues
- No issue associated -