feat: add checkAfterItems in builders #2503
Open
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
checkAfterItems
in metadata-check builder.This new option allows devs to deactivate checks on items set in "after" property.
This will allow documenting breaking changes in modules which don't have access to the complete metadata.
For example with this migration change:
When running builder @o3r/components:check-config-migration-metadata, the metadata file is the one of module @mylib/moduleA and doesn't contain any metadata from other modules (@mylib/moduleB). The check for property "bar" in config interface @mylib/moduleB#Bar will fail.
With the new option
checkAfterItems
, we can deactivate this check.Bonus: Add
packageJsonEntry
in the schema of :Related issues