Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think Frame skipping hasn't been done correctly. #4

Open
kartikpaigwar opened this issue Jan 4, 2019 · 0 comments
Open

I think Frame skipping hasn't been done correctly. #4

kartikpaigwar opened this issue Jan 4, 2019 · 0 comments

Comments

@kartikpaigwar
Copy link

kartikpaigwar commented Jan 4, 2019

According to this blog which has nicely explained the preprocessing done in actual DQN by Deep Mind, We should skip 3 consecutive frames and consider only 4rth frame. But you have added all these four consecutive frames in the buffer, which I feel is not exactly the frame skipping mentioned in the DQN paper.

for _ in range(self.frame_skipping):
# step 에서 나온 observation은 버림
observation, reward, done, info = self.env.step(action[0, 0])
next_state = self.env.get_screen()
self.add_state(next_state)

You should add the next_state at the end of the above 'for loop' not inside it. This will correct the skipping frame concept. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant