You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe this is because both this branch and the master branch are configured as a 'pure' cmake package, causing cmake to produce a non-homogenous workspace. It does build successfully if manually triggered using cmake or catkin_make_isolated, and should work in a workspace with no other packages. That said, migrating to a catkin-based workspace seems sensible to me: it's already configured as a ROS package so there's no additional overhead but it does make things a bit more ROS-standard.
However: I do observe a conflict between these proposed changes and @malban's more recent ongoing work in #34 (in the root CMakeLists and the package.xml). As far as I can tell, though, #34 does everything the diff proposes on the condition that the buildtool is marked as being catkin (instead of cmake). So, my recommendation here would be to make that change over there and then close this issue once that's merged.
I couldn't build the
csm_eigen
branch usingcatkin build
. Indeed, the topCMakeLists.txt
doesn't include (subdirs
) the one insrc
, so the build passes but it doesn't do anything at all. See:https://github.com/AndreaCensi/csm/blob/csm_eigen/CMakeLists.txt
Therefore, I've decided to fork and catkinize it. See this compare diff:
https://github.com/AndreaCensi/csm/compare/csm_eigen...clearpathrobotics:catkinize_csm_eigen?expand=1
@csprunk @RainerKuemmerle If you are OK with a change like that, I can open a PR.
The text was updated successfully, but these errors were encountered: