From 6aacab77f06eeffb6e4fb920b30000268210c455 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Mon, 28 Aug 2023 17:01:43 +0200 Subject: [PATCH 01/15] Fix boost compil --- src/libs/antares/study/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/antares/study/CMakeLists.txt b/src/libs/antares/study/CMakeLists.txt index 99442a8e7d..15ad16fc3b 100644 --- a/src/libs/antares/study/CMakeLists.txt +++ b/src/libs/antares/study/CMakeLists.txt @@ -427,6 +427,7 @@ add_library(Antares::study ALIAS study) target_link_libraries(study PUBLIC yuni-static-core + Boost::Boost Antares::array #xcast Antares::date #parameters Antares::inifile #parameters From cb8b3c3b6461eb47ba124aed26728339d685bde3 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Mon, 28 Aug 2023 17:06:33 +0200 Subject: [PATCH 02/15] Fix boost compil --- src/libs/antares/study/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/antares/study/CMakeLists.txt b/src/libs/antares/study/CMakeLists.txt index 15ad16fc3b..7da8e43b82 100644 --- a/src/libs/antares/study/CMakeLists.txt +++ b/src/libs/antares/study/CMakeLists.txt @@ -427,7 +427,7 @@ add_library(Antares::study ALIAS study) target_link_libraries(study PUBLIC yuni-static-core - Boost::Boost + Boost::boost Antares::array #xcast Antares::date #parameters Antares::inifile #parameters From 5df53802ee5437ea3f439013d849548032fd9e3c Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Tue, 29 Aug 2023 10:05:43 +0200 Subject: [PATCH 03/15] Fix hostname/policy link error --- src/libs/antares/logs/CMakeLists.txt | 1 + .../{sys/include/antares/sys => logs/antares/logs}/hostname.hxx | 0 src/libs/antares/logs/hostinfo.cpp | 2 +- src/libs/antares/sys/CMakeLists.txt | 1 - src/libs/antares/sys/policy.cpp | 2 +- 5 files changed, 3 insertions(+), 3 deletions(-) rename src/libs/antares/{sys/include/antares/sys => logs/antares/logs}/hostname.hxx (100%) diff --git a/src/libs/antares/logs/CMakeLists.txt b/src/libs/antares/logs/CMakeLists.txt index 4eebd0483c..c60d889df1 100644 --- a/src/libs/antares/logs/CMakeLists.txt +++ b/src/libs/antares/logs/CMakeLists.txt @@ -4,6 +4,7 @@ set(HEADERS antares/${PROJ}/logs.h antares/${PROJ}/logs.hxx antares/${PROJ}/hostinfo.h + antares/${PROJ}/hostname.hxx ) set(SRC_LOGS ${HEADERS} diff --git a/src/libs/antares/sys/include/antares/sys/hostname.hxx b/src/libs/antares/logs/antares/logs/hostname.hxx similarity index 100% rename from src/libs/antares/sys/include/antares/sys/hostname.hxx rename to src/libs/antares/logs/antares/logs/hostname.hxx diff --git a/src/libs/antares/logs/hostinfo.cpp b/src/libs/antares/logs/hostinfo.cpp index 9d352541f7..009a0a96b4 100644 --- a/src/libs/antares/logs/hostinfo.cpp +++ b/src/libs/antares/logs/hostinfo.cpp @@ -30,7 +30,7 @@ #include "antares/logs/hostinfo.h" #include -#include "antares/sys/hostname.hxx" +#include "antares/logs/hostname.hxx" using namespace Yuni; using namespace Antares; diff --git a/src/libs/antares/sys/CMakeLists.txt b/src/libs/antares/sys/CMakeLists.txt index 0f3ff8a1fb..b0cd415915 100644 --- a/src/libs/antares/sys/CMakeLists.txt +++ b/src/libs/antares/sys/CMakeLists.txt @@ -2,7 +2,6 @@ set(PROJ sys) set(HEADERS include/antares/${PROJ}/appdata.h include/antares/${PROJ}/policy.h - include/antares/${PROJ}/hostname.hxx ) set(SRC_PROJ ${HEADERS} diff --git a/src/libs/antares/sys/policy.cpp b/src/libs/antares/sys/policy.cpp index 05dc41f76f..c45de88af5 100644 --- a/src/libs/antares/sys/policy.cpp +++ b/src/libs/antares/sys/policy.cpp @@ -31,7 +31,7 @@ #include "antares/sys/appdata.h" #include #include -#include "antares/sys/hostname.hxx" +#include #include "../config.h" #include #include From a6d258af70b6d271b44c2867fb4d3c9ad2a8af19 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Tue, 29 Aug 2023 13:22:39 +0200 Subject: [PATCH 04/15] Add missing link to thermal definition --- src/libs/antares/checks/CMakeLists.txt | 19 +++++------ .../antares/checks/checkLoadedInputData.cpp | 4 +-- .../antares/correlation/correlation.h | 2 +- src/libs/antares/study/CMakeLists.txt | 1 - src/libs/antares/study/area.h | 32 ------------------- .../antares/study/parts/hydro/container.h | 2 +- .../study/parts/renewable/cluster_list.cpp | 2 +- src/libs/antares/study/ui-runtimeinfos.h | 2 +- src/solver/ts-generator/xcast/predicate.hxx | 2 +- .../variable/commons/links/links.cpp.inc.hxx | 2 +- .../thermal-price-definition/CMakeLists.txt | 1 + .../thermal-price-definition.cpp | 2 -- src/ui/simulator/application/study.cpp | 6 +--- .../toolbox/components/map/nodes/connection.h | 2 +- 14 files changed, 21 insertions(+), 58 deletions(-) delete mode 100644 src/libs/antares/study/area.h diff --git a/src/libs/antares/checks/CMakeLists.txt b/src/libs/antares/checks/CMakeLists.txt index 6e5b9f4251..6906efca3b 100644 --- a/src/libs/antares/checks/CMakeLists.txt +++ b/src/libs/antares/checks/CMakeLists.txt @@ -11,15 +11,15 @@ add_library(Antares::checks ALIAS checks) target_include_directories(checks PRIVATE - ${CMAKE_SOURCE_DIR}/libs/ - ${CMAKE_SOURCE_DIR}/libs/antares/study - ${CMAKE_SOURCE_DIR}/libs/antares/inifile #adq-patch-params - ${CMAKE_SOURCE_DIR}/libs/antares/array #area - ${CMAKE_SOURCE_DIR}/libs/antares/io #area -> matrix -> io - ${CMAKE_SOURCE_DIR}/libs/antares/date #area -> parameter -> date - ${CMAKE_SOURCE_DIR}/libs/antares/writer #area -> antares/parts/thermal/cluster -> writer - ${CMAKE_SOURCE_DIR}/libs/antares/jit #area -> matrix -> jit - ${CMAKE_SOURCE_DIR}/libs/antares/memory/include #area -> matrix -> memory +# ${CMAKE_SOURCE_DIR}/libs/ +# ${CMAKE_SOURCE_DIR}/libs/antares/study +# ${CMAKE_SOURCE_DIR}/libs/antares/inifile #adq-patch-params +# ${CMAKE_SOURCE_DIR}/libs/antares/array #area +# ${CMAKE_SOURCE_DIR}/libs/antares/io #area -> matrix -> io +# ${CMAKE_SOURCE_DIR}/libs/antares/date #area -> parameter -> date +# ${CMAKE_SOURCE_DIR}/libs/antares/writer #area -> antares/parts/thermal/cluster -> writer +# ${CMAKE_SOURCE_DIR}/libs/antares/jit #area -> matrix -> jit +# ${CMAKE_SOURCE_DIR}/libs/antares/memory/include #area -> matrix -> memory PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ) @@ -30,4 +30,5 @@ target_link_libraries(checks yuni-static-core exception Antares::study # cpp -> area + libantares-core ) \ No newline at end of file diff --git a/src/libs/antares/checks/checkLoadedInputData.cpp b/src/libs/antares/checks/checkLoadedInputData.cpp index 672b68d580..3fcad20e02 100644 --- a/src/libs/antares/checks/checkLoadedInputData.cpp +++ b/src/libs/antares/checks/checkLoadedInputData.cpp @@ -27,10 +27,10 @@ #include #include -#include +#include #include -#include "area.h" +#include namespace Antares::Check { diff --git a/src/libs/antares/correlation/antares/correlation/correlation.h b/src/libs/antares/correlation/antares/correlation/correlation.h index e9043597e4..f69f23bcd7 100644 --- a/src/libs/antares/correlation/antares/correlation/correlation.h +++ b/src/libs/antares/correlation/antares/correlation/correlation.h @@ -243,7 +243,7 @@ IniFile* InterAreaCorrelationSaveToIniFile(const Matrix<>* m, const AreaList* l) } // namespace Data } // namespace Antares -#include "../study/area.h" +#include #include "correlation.hxx" #endif /* __ANTARES_LIBS_ARRAY_CORRELATION_H__ */ diff --git a/src/libs/antares/study/CMakeLists.txt b/src/libs/antares/study/CMakeLists.txt index 7da8e43b82..e43f5ecdb6 100644 --- a/src/libs/antares/study/CMakeLists.txt +++ b/src/libs/antares/study/CMakeLists.txt @@ -153,7 +153,6 @@ source_group("study\\action\\handler\\antares study\\constraint" FILES ${SRC_STU set(SRC_AREAS - area.h area/constants.h area/area.h area/area.hxx diff --git a/src/libs/antares/study/area.h b/src/libs/antares/study/area.h deleted file mode 100644 index d9efa3204a..0000000000 --- a/src/libs/antares/study/area.h +++ /dev/null @@ -1,32 +0,0 @@ -/* -** Copyright 2007-2023 RTE -** Authors: Antares_Simulator Team -** -** This file is part of Antares_Simulator. -** -** Antares_Simulator is free software: you can redistribute it and/or modify -** it under the terms of the GNU General Public License as published by -** the Free Software Foundation, either version 3 of the License, or -** (at your option) any later version. -** -** There are special exceptions to the terms and conditions of the -** license as they are applied to this software. View the full text of -** the exceptions in file COPYING.txt in the directory of this software -** distribution -** -** Antares_Simulator is distributed in the hope that it will be useful, -** but WITHOUT ANY WARRANTY; without even the implied warranty of -** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -** GNU General Public License for more details. -** -** You should have received a copy of the GNU General Public License -** along with Antares_Simulator. If not, see . -** -** SPDX-License-Identifier: licenceRef-GPL3_WITH_RTE-Exceptions -*/ -#ifndef __ANTARES_LIBS_STUDY_AREA_H__ -#define __ANTARES_LIBS_STUDY_AREA_H__ - -#include "area/area.h" - -#endif // __ANTARES_LIBS_STUDY_AREA_H__ diff --git a/src/libs/antares/study/parts/hydro/container.h b/src/libs/antares/study/parts/hydro/container.h index 7916c02803..84f9f4cc8f 100644 --- a/src/libs/antares/study/parts/hydro/container.h +++ b/src/libs/antares/study/parts/hydro/container.h @@ -191,6 +191,6 @@ double getWeeklyModulation(const double& level /* format : in % of reservoir cap } // namespace Antares::Data -#include "../../area.h" +#include #endif /* __ANTARES_LIBS_STUDY_PARTS_HYDRO_CONTAINER_H__ */ diff --git a/src/libs/antares/study/parts/renewable/cluster_list.cpp b/src/libs/antares/study/parts/renewable/cluster_list.cpp index 6f02bfaf38..c7c01a00bd 100644 --- a/src/libs/antares/study/parts/renewable/cluster_list.cpp +++ b/src/libs/antares/study/parts/renewable/cluster_list.cpp @@ -1,7 +1,7 @@ #include "cluster_list.h" #include #include "../../study.h" -#include "../../area.h" +#include using namespace Yuni; diff --git a/src/libs/antares/study/ui-runtimeinfos.h b/src/libs/antares/study/ui-runtimeinfos.h index 5a229b40d0..3353b81b62 100644 --- a/src/libs/antares/study/ui-runtimeinfos.h +++ b/src/libs/antares/study/ui-runtimeinfos.h @@ -30,7 +30,7 @@ #include #include #include "fwd.h" -#include "area.h" +#include "area/area.h" #include "binding_constraint/BindingConstraint.h" namespace Antares diff --git a/src/solver/ts-generator/xcast/predicate.hxx b/src/solver/ts-generator/xcast/predicate.hxx index bc02a44d9d..5797a00b72 100644 --- a/src/solver/ts-generator/xcast/predicate.hxx +++ b/src/solver/ts-generator/xcast/predicate.hxx @@ -28,7 +28,7 @@ #define __SOLVER_TS_GENERATOR_XCAST_PREDICATE_HXX__ #include -#include +#include #include #include "antares/study/parts/load/prepro.h" diff --git a/src/solver/variable/commons/links/links.cpp.inc.hxx b/src/solver/variable/commons/links/links.cpp.inc.hxx index 2f79991628..fbb860b19e 100644 --- a/src/solver/variable/commons/links/links.cpp.inc.hxx +++ b/src/solver/variable/commons/links/links.cpp.inc.hxx @@ -26,7 +26,7 @@ */ #include "../../variable.h" -#include "../../area.h" +#include #include "../../setofareas.h" using namespace Yuni; diff --git a/src/tests/src/libs/antares/study/thermal-price-definition/CMakeLists.txt b/src/tests/src/libs/antares/study/thermal-price-definition/CMakeLists.txt index 3a6305ff5e..43c7aca74e 100644 --- a/src/tests/src/libs/antares/study/thermal-price-definition/CMakeLists.txt +++ b/src/tests/src/libs/antares/study/thermal-price-definition/CMakeLists.txt @@ -24,6 +24,7 @@ target_link_libraries(thermal-price-definition checks Antares::study Antares::exception + Antares::checks ) # Linux if(UNIX AND NOT APPLE) diff --git a/src/tests/src/libs/antares/study/thermal-price-definition/thermal-price-definition.cpp b/src/tests/src/libs/antares/study/thermal-price-definition/thermal-price-definition.cpp index 8bff9b724f..7748e7466d 100644 --- a/src/tests/src/libs/antares/study/thermal-price-definition/thermal-price-definition.cpp +++ b/src/tests/src/libs/antares/study/thermal-price-definition/thermal-price-definition.cpp @@ -9,12 +9,10 @@ #include #include -#include #include #include #include "cluster_list.h" -#include "container.h" const auto SEP = Yuni::IO::Separator; using namespace Antares::Data; diff --git a/src/ui/simulator/application/study.cpp b/src/ui/simulator/application/study.cpp index 3a3e7911e3..9fbf768e4e 100644 --- a/src/ui/simulator/application/study.cpp +++ b/src/ui/simulator/application/study.cpp @@ -25,10 +25,8 @@ ** SPDX-License-Identifier: licenceRef-GPL3_WITH_RTE-Exceptions */ #include "study.h" -#include -#include #include -#include +#include #include #include @@ -44,7 +42,6 @@ #include "../windows/saveas.h" #include "main.h" #include "menus.h" -#include #include "../windows/inspector/inspector.h" #include @@ -52,7 +49,6 @@ #include "wait.h" #include #include -#include "../toolbox/dispatcher/study.h" #include "../windows/startupwizard.h" #include diff --git a/src/ui/simulator/toolbox/components/map/nodes/connection.h b/src/ui/simulator/toolbox/components/map/nodes/connection.h index 9cd8e249bf..31fe996072 100644 --- a/src/ui/simulator/toolbox/components/map/nodes/connection.h +++ b/src/ui/simulator/toolbox/components/map/nodes/connection.h @@ -30,7 +30,7 @@ #include "item.h" #include "node.h" #include "../tools/tool.h" -#include +#include namespace Antares { From e3972551712f4bd064de0f931e6c321350e1dee3 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Tue, 29 Aug 2023 15:16:10 +0200 Subject: [PATCH 05/15] Make yuni public in lib-matrix for test --- src/tests/src/libs/antares/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/src/libs/antares/CMakeLists.txt b/src/tests/src/libs/antares/CMakeLists.txt index 61ad648f26..6f450180aa 100644 --- a/src/tests/src/libs/antares/CMakeLists.txt +++ b/src/tests/src/libs/antares/CMakeLists.txt @@ -18,7 +18,7 @@ set(SRC_MATRIX_LIB add_library(lib-matrix ${SRC_MATRIX_LIB}) target_link_libraries(lib-matrix - PRIVATE + PUBLIC yuni-static-core ) From 1bb58283fc1076f136509d3e487caf9064331340 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Tue, 29 Aug 2023 16:24:11 +0200 Subject: [PATCH 06/15] Loosen build parallelization --- .github/workflows/windows-release.yml | 2 +- .github/workflows/windows-vcpkg.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/windows-release.yml b/.github/workflows/windows-release.yml index cdd36467db..f090233732 100644 --- a/.github/workflows/windows-release.yml +++ b/.github/workflows/windows-release.yml @@ -103,7 +103,7 @@ jobs: - name: Build run: | - cmake --build _build --config release -j2 + cmake --build _build --config release - name: Remove OR-Tools install directory to free some disk space shell: bash diff --git a/.github/workflows/windows-vcpkg.yml b/.github/workflows/windows-vcpkg.yml index 3a9bc71d65..0b065aaea2 100644 --- a/.github/workflows/windows-vcpkg.yml +++ b/.github/workflows/windows-vcpkg.yml @@ -118,7 +118,7 @@ jobs: - name: Build shell: bash run: | - cmake --build _build --config release -j2 + cmake --build _build --config release - name: Run unfeasibility-related tests run: | From f3dd7b5b559ddce2e81bd82939680611f4d638e4 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Tue, 29 Aug 2023 16:24:32 +0200 Subject: [PATCH 07/15] Try fix --- src/tests/src/libs/antares/CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/src/libs/antares/CMakeLists.txt b/src/tests/src/libs/antares/CMakeLists.txt index 6f450180aa..e8d7ea3338 100644 --- a/src/tests/src/libs/antares/CMakeLists.txt +++ b/src/tests/src/libs/antares/CMakeLists.txt @@ -24,10 +24,7 @@ target_link_libraries(lib-matrix target_include_directories(lib-matrix PRIVATE - "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_CURRENT_SOURCE_DIR}/logs" - "${CMAKE_SOURCE_DIR}/tests/src/libs" - ) # Storing lib-matrix under the folder Unit-tests in the IDE From 26b47b0e13ea592c9c67a4aa836acd72e274e505 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Wed, 30 Aug 2023 09:26:14 +0200 Subject: [PATCH 08/15] Remove extra include to log causing link error --- src/tests/src/libs/antares/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tests/src/libs/antares/CMakeLists.txt b/src/tests/src/libs/antares/CMakeLists.txt index e8d7ea3338..b4c1d790c9 100644 --- a/src/tests/src/libs/antares/CMakeLists.txt +++ b/src/tests/src/libs/antares/CMakeLists.txt @@ -46,7 +46,6 @@ target_include_directories(tests-matrix-save "${src_libs_antares}/array" "${src_libs_antares}/io" "${src_libs_antares}/jit" - "${src_libs_antares}/logs" "${src_libs_antares}/memory/include" "${CMAKE_CURRENT_SOURCE_DIR}/logs" "${CMAKE_CURRENT_SOURCE_DIR}/jit" From 5905fe45c818dd95b2d8cfcbc4d0113c8fed9226 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Wed, 30 Aug 2023 10:50:12 +0200 Subject: [PATCH 09/15] Fix windows compilation: missing link to winsock --- src/libs/antares/logs/CMakeLists.txt | 8 ++++++-- src/solver/simulation/CMakeLists.txt | 4 ++++ src/tests/src/solver/simulation/CMakeLists.txt | 1 + .../solver/simulation/test-store-timeseries-number.cpp | 4 ++-- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/libs/antares/logs/CMakeLists.txt b/src/libs/antares/logs/CMakeLists.txt index c60d889df1..0915bc55de 100644 --- a/src/libs/antares/logs/CMakeLists.txt +++ b/src/libs/antares/logs/CMakeLists.txt @@ -17,10 +17,14 @@ source_group("misc\\logs" FILES ${SRC_LOGS}) add_library(${PROJ} ${SRC_LOGS}) add_library(Antares::${PROJ} ALIAS ${PROJ}) +if(WIN32) + find_library(WSOCK32_LIBRARY wsock32) + find_library(WS2_32_LIBRARY ws2_32) + target_link_libraries(${PROJ} PUBLIC wsock32 ws2_32) +endif() target_link_libraries(${PROJ} - PRIVATE + PUBLIC yuni-static-core - Antares::sys ) target_include_directories(${PROJ} diff --git a/src/solver/simulation/CMakeLists.txt b/src/solver/simulation/CMakeLists.txt index 6ab6edc380..2fb31c1159 100644 --- a/src/solver/simulation/CMakeLists.txt +++ b/src/solver/simulation/CMakeLists.txt @@ -58,4 +58,8 @@ target_include_directories(libantares-solver-simulation PUBLIC target_link_libraries(libantares-solver-simulation PRIVATE Antares::infoCollection + PUBLIC + yuni-static-core + Antares::study + Antares::result_writer ) diff --git a/src/tests/src/solver/simulation/CMakeLists.txt b/src/tests/src/solver/simulation/CMakeLists.txt index acf826f1c8..7dcdba69e7 100644 --- a/src/tests/src/solver/simulation/CMakeLists.txt +++ b/src/tests/src/solver/simulation/CMakeLists.txt @@ -45,6 +45,7 @@ target_link_libraries(test-store-timeseries-number test_utils_unit libantares-solver-simulation Antares::study + Antares::result_writer ) # Linux diff --git a/src/tests/src/solver/simulation/test-store-timeseries-number.cpp b/src/tests/src/solver/simulation/test-store-timeseries-number.cpp index 8cbac1ce83..8066be02f2 100644 --- a/src/tests/src/solver/simulation/test-store-timeseries-number.cpp +++ b/src/tests/src/solver/simulation/test-store-timeseries-number.cpp @@ -12,8 +12,8 @@ #include "timeseries-numbers.h" #include "BindingConstraintsTimeSeriesNumbersWriter.h" #include "utils.h" -#include "antares/writer/writer_factory.h" -#include "antares/writer/result_format.h" +#include +#include using namespace Antares::Solver; using namespace Antares::Data; From 71fede58095e88a079bc15dbf9f628d2accfd8d1 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Wed, 30 Aug 2023 11:46:51 +0200 Subject: [PATCH 10/15] Fix UI compilation --- src/ui/simulator/toolbox/components/datagrid/dbgrid.h | 1 + .../simulator/toolbox/components/datagrid/filter/operator.list.h | 1 + src/ui/simulator/toolbox/create.h | 1 + 3 files changed, 3 insertions(+) diff --git a/src/ui/simulator/toolbox/components/datagrid/dbgrid.h b/src/ui/simulator/toolbox/components/datagrid/dbgrid.h index 72169d7a04..a7f32b98b8 100644 --- a/src/ui/simulator/toolbox/components/datagrid/dbgrid.h +++ b/src/ui/simulator/toolbox/components/datagrid/dbgrid.h @@ -28,6 +28,7 @@ #define __ANTARES_TOOLBOX_COMPONENT_DATAGRID_DBGRID_H__ #include +#include namespace Antares { diff --git a/src/ui/simulator/toolbox/components/datagrid/filter/operator.list.h b/src/ui/simulator/toolbox/components/datagrid/filter/operator.list.h index 9f1649845b..e3b7b0a58c 100644 --- a/src/ui/simulator/toolbox/components/datagrid/filter/operator.list.h +++ b/src/ui/simulator/toolbox/components/datagrid/filter/operator.list.h @@ -28,6 +28,7 @@ #define __ANTARES_TOOLBOX_FILTER_OPERATOR_LIST_H__ #include +#include #include namespace Antares diff --git a/src/ui/simulator/toolbox/create.h b/src/ui/simulator/toolbox/create.h index 21aa3ec460..adb2402d91 100644 --- a/src/ui/simulator/toolbox/create.h +++ b/src/ui/simulator/toolbox/create.h @@ -30,6 +30,7 @@ #include #include #include +#include namespace Antares { From 463c4a3ea7de3f2ae427974dcd2d48918fd42bf3 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Fri, 1 Sep 2023 16:26:28 +0200 Subject: [PATCH 11/15] Reestablish -j2 build option as it doesn't change anything removing it --- .github/workflows/windows-release.yml | 2 +- .github/workflows/windows-vcpkg.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/windows-release.yml b/.github/workflows/windows-release.yml index f090233732..cdd36467db 100644 --- a/.github/workflows/windows-release.yml +++ b/.github/workflows/windows-release.yml @@ -103,7 +103,7 @@ jobs: - name: Build run: | - cmake --build _build --config release + cmake --build _build --config release -j2 - name: Remove OR-Tools install directory to free some disk space shell: bash diff --git a/.github/workflows/windows-vcpkg.yml b/.github/workflows/windows-vcpkg.yml index 0b065aaea2..3a9bc71d65 100644 --- a/.github/workflows/windows-vcpkg.yml +++ b/.github/workflows/windows-vcpkg.yml @@ -118,7 +118,7 @@ jobs: - name: Build shell: bash run: | - cmake --build _build --config release + cmake --build _build --config release -j2 - name: Run unfeasibility-related tests run: | From e7e18f00ed86d7294f594b25be926e74c73c38c9 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Fri, 1 Sep 2023 16:27:27 +0200 Subject: [PATCH 12/15] Remove commented code --- src/libs/antares/checks/CMakeLists.txt | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/libs/antares/checks/CMakeLists.txt b/src/libs/antares/checks/CMakeLists.txt index 6906efca3b..8846d0eb41 100644 --- a/src/libs/antares/checks/CMakeLists.txt +++ b/src/libs/antares/checks/CMakeLists.txt @@ -10,16 +10,6 @@ add_library(checks add_library(Antares::checks ALIAS checks) target_include_directories(checks - PRIVATE -# ${CMAKE_SOURCE_DIR}/libs/ -# ${CMAKE_SOURCE_DIR}/libs/antares/study -# ${CMAKE_SOURCE_DIR}/libs/antares/inifile #adq-patch-params -# ${CMAKE_SOURCE_DIR}/libs/antares/array #area -# ${CMAKE_SOURCE_DIR}/libs/antares/io #area -> matrix -> io -# ${CMAKE_SOURCE_DIR}/libs/antares/date #area -> parameter -> date -# ${CMAKE_SOURCE_DIR}/libs/antares/writer #area -> antares/parts/thermal/cluster -> writer -# ${CMAKE_SOURCE_DIR}/libs/antares/jit #area -> matrix -> jit -# ${CMAKE_SOURCE_DIR}/libs/antares/memory/include #area -> matrix -> memory PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} ) From 668a8f15b9d45aa797da3aecc3a4cc8433eaa620 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Fri, 1 Sep 2023 17:18:21 +0200 Subject: [PATCH 13/15] Use proper casing for s(S)ettings struct --- src/libs/antares/date/antares/date/date.h | 6 +++--- src/libs/antares/date/date.cpp | 2 +- src/libs/antares/study/CMakeLists.txt | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/libs/antares/date/antares/date/date.h b/src/libs/antares/date/antares/date/date.h index 4800e4178b..08bc29330e 100644 --- a/src/libs/antares/date/antares/date/date.h +++ b/src/libs/antares/date/antares/date/date.h @@ -292,7 +292,7 @@ class Calendar } mapping; //! The calendar settings - struct settings + struct Settings { //! Day of the week for the 1rst January DayOfTheWeek weekday1rstJanuary; @@ -355,7 +355,7 @@ class Calendar ** Reset the calendar from an instance of the class \p Parameters, ** \param parameters Simulation settings */ - void reset(settings settings); + void reset(Settings settings); /*! ** \brief Export the whole calendar into a CSV file @@ -365,7 +365,7 @@ class Calendar bool saveToCSVFile(const AnyString& filename) const; private: - settings settings_; + Settings settings_; }; // class Calendar } // namespace Date diff --git a/src/libs/antares/date/date.cpp b/src/libs/antares/date/date.cpp index f7bd1719dd..1572c27cd3 100644 --- a/src/libs/antares/date/date.cpp +++ b/src/libs/antares/date/date.cpp @@ -402,7 +402,7 @@ Calendar::Calendar() settings_.weekday1rstJanuary = monday; } -void Calendar::reset(settings settings) +void Calendar::reset(Settings settings) { settings_ = settings; reset(); diff --git a/src/libs/antares/study/CMakeLists.txt b/src/libs/antares/study/CMakeLists.txt index e43f5ecdb6..47b0d6f3d5 100644 --- a/src/libs/antares/study/CMakeLists.txt +++ b/src/libs/antares/study/CMakeLists.txt @@ -442,6 +442,7 @@ target_link_libraries(study ) target_include_directories(study - PUBLIC - ${CMAKE_CURRENT_SOURCE_DIR}/../.. + PUBLIC + ${CMAKE_CURRENT_SOURCE_DIR}/../.. #Dirty trick to allow inclusion via + # Make more than just study visible but it's the lesser evil for now ) \ No newline at end of file From 015599dd1f4853ec774d1897b771c772461b0b08 Mon Sep 17 00:00:00 2001 From: Jason Marechal Date: Fri, 1 Sep 2023 17:18:51 +0200 Subject: [PATCH 14/15] Remove duplicated link dependency --- src/libs/antares/writer/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libs/antares/writer/CMakeLists.txt b/src/libs/antares/writer/CMakeLists.txt index 1c99d75e35..ef7129cc51 100644 --- a/src/libs/antares/writer/CMakeLists.txt +++ b/src/libs/antares/writer/CMakeLists.txt @@ -33,7 +33,6 @@ target_link_libraries(result_writer PUBLIC Antares::benchmarking PRIVATE - Antares::benchmarking yuni-static-core MINIZIP::minizip logs From 28e1e5d2f4161e46b515e2244f95030d55b7579e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jason=20Mar=C3=A9chal?= <45510813+JasonMarechal25@users.noreply.github.com> Date: Tue, 12 Sep 2023 09:48:23 +0200 Subject: [PATCH 15/15] Revert removing -j options during CI --- .github/workflows/windows-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-release.yml b/.github/workflows/windows-release.yml index f090233732..cdd36467db 100644 --- a/.github/workflows/windows-release.yml +++ b/.github/workflows/windows-release.yml @@ -103,7 +103,7 @@ jobs: - name: Build run: | - cmake --build _build --config release + cmake --build _build --config release -j2 - name: Remove OR-Tools install directory to free some disk space shell: bash