Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DataSeriesHydro :: loadFromFolder #1701

Closed
guilpier-code opened this issue Oct 12, 2023 · 0 comments
Closed

Simplify DataSeriesHydro :: loadFromFolder #1701

guilpier-code opened this issue Oct 12, 2023 · 0 comments
Assignees
@nikolaredstork
Labels
refactoring
Milestone
v8.8.1

Comments

@guilpier-code
Copy link
Contributor

guilpier-code commented Oct 12, 2023 •
edited
Loading

We should simplify methods :

  • DataSeriesHydro::loadFromFolder
  • DataSeriesHydro::checkMinGenTsNumber

Both very hard to read, on the model of what was done for DataSeriesHydro::LoadMaxPower

Doing this, we treat this remark, left for another PR.

And this remark as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikolaredstork nikolaredstork

Labels
refactoring
Projects
None yet
Milestone
v8.8.1
Development

No branches or pull requests
3 participants
@guilpier-code @payetvin @nikolaredstork